From: Sean Rhodes <sean@starlabs.systems>
To: chrome-platform@lists.linux.dev
Cc: "Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Denis Benato" <denis.benato@linux.dev>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Prasanth Ksr" <prasanth.ksr@dell.com>,
"Jorge Lopez" <jorge.lopez2@hp.com>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
"Joshua Grisham" <josh@joshuagrisham.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com,
"Sean Rhodes" <sean@starlabs.systems>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Chen-Yu Tsai" <wenst@chromium.org>,
"Tzung-Bi Shih" <tzungbi@kernel.org>,
"Brian Norris" <briannorris@chromium.org>,
"Julius Werner" <jwerner@chromium.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Eric Biggers" <ebiggers@kernel.org>,
"Luca Weiss" <luca.weiss@fairphone.com>,
"Michal Simek" <michal.simek@amd.com>,
"Sven Peter" <sven@kernel.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Danilo Krummrich" <dakr@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Titouan Ameline de Cadeville" <titouan.ameline@gmail.com>,
"Kees Cook" <kees@kernel.org>,
dri-devel@lists.freedesktop.org,
"Oliver Lin" <oliver@liuxiaozhen.dev>
Subject: [PATCH v10 1/4] platform/x86: Sort firmware attributes class includes
Date: Tue, 28 Jul 2026 09:20:46 +0100 [thread overview]
Message-ID: <6f133bb3fc42d2408037033aefcd2cad6d724470.1785226809.git.sean@starlabs.systems> (raw)
In-Reply-To: <cover.1785226809.git.sean@starlabs.systems>
Move firmware_attributes_class.h into the main include block and sort the
affected includes. This lets the header move replace each include in place.
Suggested-by: Derek J. Clark <derekjohn.clark@gmail.com>
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
drivers/platform/x86/asus-armoury.c | 2 +-
drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 9 +++++----
drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 9 +++++----
drivers/platform/x86/lenovo/think-lmi.c | 5 +++--
drivers/platform/x86/lenovo/wmi-other.c | 2 +-
drivers/platform/x86/samsung-galaxybook.c | 3 ++-
6 files changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
index 495dc1e31d40..f3d8c5a85762 100644
--- a/drivers/platform/x86/asus-armoury.c
+++ b/drivers/platform/x86/asus-armoury.c
@@ -20,6 +20,7 @@
#include <linux/dmi.h>
#include <linux/err.h>
#include <linux/errno.h>
+#include "firmware_attributes_class.h"
#include <linux/fs.h>
#include <linux/kernel.h>
#include <linux/kmod.h>
@@ -34,7 +35,6 @@
#include <linux/sysfs.h>
#include "asus-armoury.h"
-#include "firmware_attributes_class.h"
#define ASUS_NB_WMI_EVENT_GUID "0B3CBB35-E3C2-45ED-91C2-4C5A6D195D1C"
diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
index ab46a023cc34..4ff9003c6589 100644
--- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
+++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
@@ -8,18 +8,19 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/align.h>
-#include <linux/fs.h>
#include <linux/dmi.h>
-#include <linux/module.h>
+#include "../../firmware_attributes_class.h"
+#include <linux/fs.h>
#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/nls.h>
#include <linux/string.h>
#include <linux/sysfs.h>
#include <linux/wmi.h>
+
#include "dell-wmi-sysman.h"
-#include "../../firmware_attributes_class.h"
#define MAX_TYPES 4
-#include <linux/nls.h>
struct wmi_sysman_priv wmi_priv = {
.mutex = __MUTEX_INITIALIZER(wmi_priv.mutex),
diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
index 27fd6cd21529..1965a329be48 100644
--- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
+++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
@@ -7,16 +7,17 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+#include <linux/errno.h>
+#include "../../firmware_attributes_class.h"
#include <linux/fs.h>
-#include <linux/module.h>
#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/nls.h>
#include <linux/printk.h>
#include <linux/string.h>
#include <linux/wmi.h>
+
#include "bioscfg.h"
-#include "../../firmware_attributes_class.h"
-#include <linux/nls.h>
-#include <linux/errno.h>
MODULE_AUTHOR("Jorge Lopez <jorge.lopez2@hp.com>");
MODULE_DESCRIPTION("HP BIOS Configuration Driver");
diff --git a/drivers/platform/x86/lenovo/think-lmi.c b/drivers/platform/x86/lenovo/think-lmi.c
index e215e86e3db7..9e4b3e973de9 100644
--- a/drivers/platform/x86/lenovo/think-lmi.c
+++ b/drivers/platform/x86/lenovo/think-lmi.c
@@ -13,14 +13,15 @@
#include <linux/acpi.h>
#include <linux/array_size.h>
+#include <linux/dmi.h>
#include <linux/errno.h>
+#include "../firmware_attributes_class.h"
#include <linux/fs.h>
#include <linux/mutex.h>
#include <linux/string_helpers.h>
#include <linux/types.h>
-#include <linux/dmi.h>
#include <linux/wmi.h>
-#include "../firmware_attributes_class.h"
+
#include "think-lmi.h"
static bool debug_support;
diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86/lenovo/wmi-other.c
index fbb32bf404f2..fdebaa0a9992 100644
--- a/drivers/platform/x86/lenovo/wmi-other.c
+++ b/drivers/platform/x86/lenovo/wmi-other.c
@@ -33,6 +33,7 @@
#include <linux/container_of.h>
#include <linux/device.h>
#include <linux/export.h>
+#include "../firmware_attributes_class.h"
#include <linux/gfp_types.h>
#include <linux/hwmon.h>
#include <linux/idr.h>
@@ -50,7 +51,6 @@
#include "wmi-capdata.h"
#include "wmi-events.h"
#include "wmi-helpers.h"
-#include "../firmware_attributes_class.h"
#define LENOVO_OTHER_MODE_GUID "DC2A8805-3A8C-41BA-A6F7-092E0089CD3B"
diff --git a/drivers/platform/x86/samsung-galaxybook.c b/drivers/platform/x86/samsung-galaxybook.c
index 6382af0b106c..74103c00b0c8 100644
--- a/drivers/platform/x86/samsung-galaxybook.c
+++ b/drivers/platform/x86/samsung-galaxybook.c
@@ -14,6 +14,7 @@
#include <linux/acpi.h>
#include <linux/bits.h>
#include <linux/err.h>
+#include "firmware_attributes_class.h"
#include <linux/i8042.h>
#include <linux/init.h>
#include <linux/input.h>
@@ -27,8 +28,8 @@
#include <linux/sysfs.h>
#include <linux/uuid.h>
#include <linux/workqueue.h>
+
#include <acpi/battery.h>
-#include "firmware_attributes_class.h"
#define DRIVER_NAME "samsung-galaxybook"
next prev parent reply other threads:[~2026-07-28 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 8:20 [PATCH v10 0/4] coreboot CFR firmware attributes Sean Rhodes
2026-07-28 8:20 ` Sean Rhodes [this message]
2026-07-28 8:20 ` [PATCH v10 2/4] firmware: Move firmware attributes class helper Sean Rhodes
2026-07-28 8:20 ` [PATCH v10 3/4] firmware: Rename google firmware directory to coreboot Sean Rhodes
2026-07-28 8:20 ` [PATCH v10 4/4] firmware: coreboot: Add CFR firmware attributes driver Sean Rhodes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f133bb3fc42d2408037033aefcd2cad6d724470.1785226809.git.sean@starlabs.systems \
--to=sean@starlabs.systems \
--cc=Dell.Client.Kernel@dell.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=chenhuacai@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=corentin.chary@gmail.com \
--cc=dakr@kernel.org \
--cc=denis.benato@linux.dev \
--cc=derekjohn.clark@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiggers@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=geert@linux-m68k.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jorge.lopez2@hp.com \
--cc=josh@joshuagrisham.com \
--cc=jwerner@chromium.org \
--cc=kees@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=luke@ljones.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=mripard@kernel.org \
--cc=mst@redhat.com \
--cc=o-takashi@sakamocchi.jp \
--cc=oliver@liuxiaozhen.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=prasanth.ksr@dell.com \
--cc=simona@ffwll.ch \
--cc=sven@kernel.org \
--cc=titouan.ameline@gmail.com \
--cc=tzimmermann@suse.de \
--cc=tzungbi@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®