From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Hitesh Patel <hitesh@ebytelogic.com>, linux-media@vger.kernel.org
Cc: gjorgji.rosikopulos@oss.qualcomm.com, bod@kernel.org,
mchehab@kernel.org, vladimir.zapolskiy@linaro.org,
loic.poulain@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com,
atanas.filipov@oss.qualcomm.com,
jigarkumar.zala@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, ravi@ebytelogic.com
Subject: Re: [PATCH v4 1/4] media: qcom: camss: csid: Match the current set_fmt pad op signature
Date: Mon, 12 Oct 2026 14:46:05 +0100 [thread overview]
Message-ID: <6f40cf25-1967-4a7a-9952-a0fba3bb5fe6@linaro.org> (raw)
In-Reply-To: <20261012120542.1140157-2-hitesh@ebytelogic.com>
On 12/10/2026 13:05, Hitesh Patel wrote:
> v4l2_subdev_pad_ops::set_fmt gained a
> const struct v4l2_subdev_client_info * parameter, so
> csid_streams_set_format() no longer matches the op it is assigned to
> and the driver fails to build with -Werror=incompatible-pointer-types.
>
> Signed-off-by: Hitesh Patel <hitesh@ebytelogic.com>
> ---
> drivers/media/platform/qcom/camss/camss-csid.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
> index 2559ebe98..991275398 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid.c
> @@ -1696,6 +1696,7 @@ static int csid_streams_get_format(struct v4l2_subdev *sd,
> * Return -EINVAL or zero on success
> */
> static int csid_streams_set_format(struct v4l2_subdev *sd,
> + const struct v4l2_subdev_client_info *ci,
> struct v4l2_subdev_state *sd_state,
> struct v4l2_subdev_format *fmt)
> {
Please add an appropriate Fixes: tag and Cc: stable@vger.kernel.org
---
bod
next prev parent reply other threads:[~2026-10-12 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 12:05 [PATCH v4 0/4] media: qcom: camss: rebase fixes and SC7280 enablement for the streams API Hitesh Patel
2026-10-12 12:05 ` [PATCH v4 1/4] media: qcom: camss: csid: Match the current set_fmt pad op signature Hitesh Patel
2026-10-12 13:46 ` Bryan O'Donoghue [this message]
2026-10-12 13:47 ` Bryan O'Donoghue
2026-10-12 12:05 ` [PATCH v4 2/4] media: qcom: camss: Set the streams API flag per SoC Hitesh Patel
2026-10-12 23:57 ` Bryan O'Donoghue
2026-10-12 12:05 ` [PATCH v4 3/4] media: qcom: camss: Enable the streams API on SC7280 Hitesh Patel
2026-10-12 12:05 ` [PATCH v4 4/4] media: qcom: camss: Do not link CSID source pads the CSID does not have Hitesh Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f40cf25-1967-4a7a-9952-a0fba3bb5fe6@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=atanas.filipov@oss.qualcomm.com \
--cc=bod@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gjorgji.rosikopulos@oss.qualcomm.com \
--cc=hitesh@ebytelogic.com \
--cc=jigarkumar.zala@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=ravi@ebytelogic.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®