From: Bryan O'Donoghue <bod@kernel.org>
To: Hitesh Patel <hitesh@ebytelogic.com>, linux-media@vger.kernel.org
Cc: gjorgji.rosikopulos@oss.qualcomm.com, bryan.odonoghue@linaro.org,
mchehab@kernel.org, vladimir.zapolskiy@linaro.org,
loic.poulain@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com,
atanas.filipov@oss.qualcomm.com,
jigarkumar.zala@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, ravi@ebytelogic.com
Subject: Re: [PATCH v4 2/4] media: qcom: camss: Set the streams API flag per SoC
Date: Tue, 13 Oct 2026 00:57:04 +0100 [thread overview]
Message-ID: <fa4625a2-d6ea-4904-a381-82f7e0f6cdbb@kernel.org> (raw)
In-Reply-To: <20261012120542.1140157-3-hitesh@ebytelogic.com>
On 12/10/2026 13:05, Hitesh Patel wrote:
> + bool streams_api = csiphy->camss->res->streams_enable;
> int ret;
> @@ -2168,7 +2168,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe,
> pads = vfe->line[i].pads;
> video_out = &vfe->line[i].video_out;
>
> - v4l2_subdev_init(sd, vfe->res->streams_enable ? &vfe_streams_v4l2_ops
> + v4l2_subdev_init(sd, vfe->camss->res->streams_enable ? &vfe_streams_v4l2_ops
> : &vfe_v4l2_ops);
> sd->internal_ops = &vfe_v4l2_internal_ops;
This is a pretty inconsistent pattern.
If you're booling in a variable, then Boole in a variable *
---
bod
next prev parent reply other threads:[~2026-10-12 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 12:05 [PATCH v4 0/4] media: qcom: camss: rebase fixes and SC7280 enablement for the streams API Hitesh Patel
2026-10-12 12:05 ` [PATCH v4 1/4] media: qcom: camss: csid: Match the current set_fmt pad op signature Hitesh Patel
2026-10-12 13:46 ` Bryan O'Donoghue
2026-10-12 13:47 ` Bryan O'Donoghue
2026-10-12 12:05 ` [PATCH v4 2/4] media: qcom: camss: Set the streams API flag per SoC Hitesh Patel
2026-10-12 23:57 ` Bryan O'Donoghue [this message]
2026-10-12 12:05 ` [PATCH v4 3/4] media: qcom: camss: Enable the streams API on SC7280 Hitesh Patel
2026-10-12 12:05 ` [PATCH v4 4/4] media: qcom: camss: Do not link CSID source pads the CSID does not have Hitesh Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa4625a2-d6ea-4904-a381-82f7e0f6cdbb@kernel.org \
--to=bod@kernel.org \
--cc=atanas.filipov@oss.qualcomm.com \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gjorgji.rosikopulos@oss.qualcomm.com \
--cc=hitesh@ebytelogic.com \
--cc=jigarkumar.zala@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=ravi@ebytelogic.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®