mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Thorsten Blum <thorsten.blum@toblux.com>,
	Nicolas Pitre <nico@fluxnic.net>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Breno Leitao" <leitao@debian.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: smc91x: Remove commented out code
Date: Tue, 28 May 2024 15:36:28 +0200	[thread overview]
Message-ID: <6f596a8bf3f0ff2c498e7b6cf922fa28bd0dbef4.camel@redhat.com> (raw)
In-Reply-To: <20240527105557.266833-2-thorsten.blum@toblux.com>

Hi,

On Mon, 2024-05-27 at 12:55 +0200, Thorsten Blum wrote:
> Remove commented out code
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
>  drivers/net/ethernet/smsc/smc91x.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
> index 78ff3af7911a..907498848028 100644
> --- a/drivers/net/ethernet/smsc/smc91x.c
> +++ b/drivers/net/ethernet/smsc/smc91x.c
> @@ -1574,12 +1574,8 @@ smc_ethtool_set_link_ksettings(struct net_device *dev,
>  		    (cmd->base.port != PORT_TP && cmd->base.port != PORT_AUI))
>  			return -EINVAL;
>  
> -//		lp->port = cmd->base.port;
>  		lp->ctl_rfduplx = cmd->base.duplex == DUPLEX_FULL;
>  
> -//		if (netif_running(dev))
> -//			smc_set_port(dev);
> -
>  		ret = 0;
>  	}
>  
This is net-next material, please re-submit targeting the correct tree
in the subj prefix.

Thanks

Paolo


  reply	other threads:[~2024-05-28 13:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 10:55 Thorsten Blum
2024-05-28 13:36 ` Paolo Abeni [this message]
2024-05-29 12:28   ` Thorsten Blum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f596a8bf3f0ff2c498e7b6cf922fa28bd0dbef4.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=thorsten.blum@toblux.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®