mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net] net: smc91x: Remove commented out code
@ 2024-05-27 10:55 Thorsten Blum
  2024-05-28 13:36 ` Paolo Abeni
  0 siblings, 1 reply; 3+ messages in thread
From: Thorsten Blum @ 2024-05-27 10:55 UTC (permalink / raw)
  To: Nicolas Pitre, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: Uwe Kleine-König, Breno Leitao, netdev, linux-kernel, Thorsten Blum

Remove commented out code

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
---
 drivers/net/ethernet/smsc/smc91x.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 78ff3af7911a..907498848028 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -1574,12 +1574,8 @@ smc_ethtool_set_link_ksettings(struct net_device *dev,
 		    (cmd->base.port != PORT_TP && cmd->base.port != PORT_AUI))
 			return -EINVAL;
 
-//		lp->port = cmd->base.port;
 		lp->ctl_rfduplx = cmd->base.duplex == DUPLEX_FULL;
 
-//		if (netif_running(dev))
-//			smc_set_port(dev);
-
 		ret = 0;
 	}
 
-- 
2.45.1


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH net] net: smc91x: Remove commented out code
  2024-05-27 10:55 [PATCH net] net: smc91x: Remove commented out code Thorsten Blum
@ 2024-05-28 13:36 ` Paolo Abeni
  2024-05-29 12:28   ` Thorsten Blum
  0 siblings, 1 reply; 3+ messages in thread
From: Paolo Abeni @ 2024-05-28 13:36 UTC (permalink / raw)
  To: Thorsten Blum, Nicolas Pitre, David S. Miller, Eric Dumazet,
	Jakub Kicinski
  Cc: Uwe Kleine-König, Breno Leitao, netdev, linux-kernel

Hi,

On Mon, 2024-05-27 at 12:55 +0200, Thorsten Blum wrote:
> Remove commented out code
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
>  drivers/net/ethernet/smsc/smc91x.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
> index 78ff3af7911a..907498848028 100644
> --- a/drivers/net/ethernet/smsc/smc91x.c
> +++ b/drivers/net/ethernet/smsc/smc91x.c
> @@ -1574,12 +1574,8 @@ smc_ethtool_set_link_ksettings(struct net_device *dev,
>  		    (cmd->base.port != PORT_TP && cmd->base.port != PORT_AUI))
>  			return -EINVAL;
>  
> -//		lp->port = cmd->base.port;
>  		lp->ctl_rfduplx = cmd->base.duplex == DUPLEX_FULL;
>  
> -//		if (netif_running(dev))
> -//			smc_set_port(dev);
> -
>  		ret = 0;
>  	}
>  
This is net-next material, please re-submit targeting the correct tree
in the subj prefix.

Thanks

Paolo


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH net] net: smc91x: Remove commented out code
  2024-05-28 13:36 ` Paolo Abeni
@ 2024-05-29 12:28   ` Thorsten Blum
  0 siblings, 0 replies; 3+ messages in thread
From: Thorsten Blum @ 2024-05-29 12:28 UTC (permalink / raw)
  To: Paolo Abeni
  Cc: Nicolas Pitre, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Uwe Kleine-König, Breno Leitao, netdev, linux-kernel

On 28. May 2024, at 15:36, Paolo Abeni <pabeni@redhat.com> wrote:
> This is net-next material, please re-submit targeting the correct tree
> in the subj prefix.

Hi Paolo, I resubmitted the patch [1] with the correct prefix.

Thanks,
Thorsten

[1] https://lore.kernel.org/linux-kernel/20240528160036.404946-2-thorsten.blum@toblux.com/

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-29 12:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-27 10:55 [PATCH net] net: smc91x: Remove commented out code Thorsten Blum
2024-05-28 13:36 ` Paolo Abeni
2024-05-29 12:28   ` Thorsten Blum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®