* [PATCH] selftests/fpu: add missing MODULE_DESCRIPTION() macro
@ 2024-06-22 14:55 Jeff Johnson
2024-06-25 14:25 ` Masahiro Yamada
2024-06-26 13:22 ` Samuel Holland
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Johnson @ 2024-06-22 14:55 UTC (permalink / raw)
To: Andrew Morton, Samuel Holland
Cc: Huacai Chen, Ingo Molnar, Jonathan Corbet, Masahiro Yamada,
Michael Ellerman, Nathan Chancellor, Nicolas Schier,
Palmer Dabbelt, Russell King, Thomas Gleixner, WANG Xuerui,
Will Deacon, linux-kernel, kernel-janitors, Jeff Johnson
make allmodconfig && make W=1 C=1 now reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_fpu.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Fixes: 9613736d852d ("selftests/fpu: move FP code to a separate translation unit")
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
lib/test_fpu_glue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/test_fpu_glue.c b/lib/test_fpu_glue.c
index eef282a2715f..074f30301f29 100644
--- a/lib/test_fpu_glue.c
+++ b/lib/test_fpu_glue.c
@@ -59,4 +59,5 @@ static void __exit test_fpu_exit(void)
module_init(test_fpu_init);
module_exit(test_fpu_exit);
+MODULE_DESCRIPTION("Test cases for floating point operations");
MODULE_LICENSE("GPL");
---
base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
change-id: 20240622-md-i386-lib-test_fpu_glue-437927d4afe3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/fpu: add missing MODULE_DESCRIPTION() macro
2024-06-22 14:55 [PATCH] selftests/fpu: add missing MODULE_DESCRIPTION() macro Jeff Johnson
@ 2024-06-25 14:25 ` Masahiro Yamada
2024-06-26 13:22 ` Samuel Holland
1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2024-06-25 14:25 UTC (permalink / raw)
To: Jeff Johnson
Cc: Andrew Morton, Samuel Holland, Huacai Chen, Ingo Molnar,
Jonathan Corbet, Michael Ellerman, Nathan Chancellor,
Nicolas Schier, Palmer Dabbelt, Russell King, Thomas Gleixner,
WANG Xuerui, Will Deacon, linux-kernel, kernel-janitors
On Sat, Jun 22, 2024 at 11:55 PM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>
> make allmodconfig && make W=1 C=1 now reports:
This is a boilerplate, but C=1 is unrelated.
W=1 actually prints this warning.
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_fpu.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Fixes: 9613736d852d ("selftests/fpu: move FP code to a separate translation unit")
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> lib/test_fpu_glue.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/test_fpu_glue.c b/lib/test_fpu_glue.c
> index eef282a2715f..074f30301f29 100644
> --- a/lib/test_fpu_glue.c
> +++ b/lib/test_fpu_glue.c
> @@ -59,4 +59,5 @@ static void __exit test_fpu_exit(void)
> module_init(test_fpu_init);
> module_exit(test_fpu_exit);
>
> +MODULE_DESCRIPTION("Test cases for floating point operations");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
> change-id: 20240622-md-i386-lib-test_fpu_glue-437927d4afe3
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/fpu: add missing MODULE_DESCRIPTION() macro
2024-06-22 14:55 [PATCH] selftests/fpu: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-25 14:25 ` Masahiro Yamada
@ 2024-06-26 13:22 ` Samuel Holland
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Holland @ 2024-06-26 13:22 UTC (permalink / raw)
To: Jeff Johnson, Andrew Morton
Cc: Huacai Chen, Ingo Molnar, Jonathan Corbet, Masahiro Yamada,
Michael Ellerman, Nathan Chancellor, Nicolas Schier,
Palmer Dabbelt, Russell King, Thomas Gleixner, WANG Xuerui,
Will Deacon, linux-kernel, kernel-janitors
On 2024-06-22 9:55 AM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 now reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_fpu.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Fixes: 9613736d852d ("selftests/fpu: move FP code to a separate translation unit")
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> lib/test_fpu_glue.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/test_fpu_glue.c b/lib/test_fpu_glue.c
> index eef282a2715f..074f30301f29 100644
> --- a/lib/test_fpu_glue.c
> +++ b/lib/test_fpu_glue.c
> @@ -59,4 +59,5 @@ static void __exit test_fpu_exit(void)
> module_init(test_fpu_init);
> module_exit(test_fpu_exit);
>
> +MODULE_DESCRIPTION("Test cases for floating point operations");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
> change-id: 20240622-md-i386-lib-test_fpu_glue-437927d4afe3
>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-26 13:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-22 14:55 [PATCH] selftests/fpu: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-25 14:25 ` Masahiro Yamada
2024-06-26 13:22 ` Samuel Holland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®