mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Gerlach <d-gerlach@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Cc: Vignesh R <vigneshr@ti.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] soc: ti: ti_sci_pm_domains: Populate name for genpd
Date: Fri, 28 Jul 2017 11:35:44 -0500	[thread overview]
Message-ID: <6f5e2270-af5f-faa3-0ec3-66948d911c87@ti.com> (raw)
In-Reply-To: <20170728163333.704-1-d-gerlach@ti.com>

Hi,
On 07/28/2017 11:33 AM, Dave Gerlach wrote:
> Commit b6a1d093f96b ("PM / Domains: Extend generic power domain
> debugfs") now creates a debugfs directory for each genpd based on the
> name of the genpd. Currently no name is given to the genpd created by
> ti_sci_pm_domains driver so because of this we see a NULL pointer
> dereferences when it is accessed on boot when the debugfs entry creation
> is attempted.
> 
> Give the genpd a name before registering it to avoid this.
> 
> Fixes: 52835d59fc6c ("soc: ti: Add ti_sci_pm_domains driver")
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> ---

Sorry for the noise, last patch had wrong email for Santosh and this one
corrects it. keystone-k2g-evm is crashing on linux-next at boot due to patch
mentioned in the change log, this patch fixes the ti_sci_pm_domains driver to
avoid this. I will also soon send a patch to address what I think is an issue in
the pm domain framework itself to avoid this crash from ever happening.

Regards,
Dave

> 
>  drivers/soc/ti/ti_sci_pm_domains.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c
> index b0b283810e72..de31b9389e2e 100644
> --- a/drivers/soc/ti/ti_sci_pm_domains.c
> +++ b/drivers/soc/ti/ti_sci_pm_domains.c
> @@ -176,6 +176,8 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev)
>  
>  	ti_sci_pd->dev = dev;
>  
> +	ti_sci_pd->pd.name = "ti_sci_pd";
> +
>  	ti_sci_pd->pd.attach_dev = ti_sci_pd_attach_dev;
>  	ti_sci_pd->pd.detach_dev = ti_sci_pd_detach_dev;
>  
> 

  reply	other threads:[~2017-07-28 16:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 16:33 Dave Gerlach
2017-07-28 16:35 ` Dave Gerlach [this message]
2017-07-28 16:53   ` santosh.shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f5e2270-af5f-faa3-0ec3-66948d911c87@ti.com \
    --to=d-gerlach@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=santosh.shilimkar@oracle.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®