* [PATCH] reset: RESET_NUVOTON_MA35D1 should depend on ARCH_MA35
@ 2023-06-06 9:55 Geert Uytterhoeven
2023-06-06 9:59 ` Ilpo Järvinen
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-06-06 9:55 UTC (permalink / raw)
To: Philipp Zabel, Ilpo Järvinen, Arnd Bergmann, Jacky Huang
Cc: linux-arm-kernel, linux-kernel, Geert Uytterhoeven
The Nuvoton MA35D1 reset controller is only present on Nuvoton MA35
SoCs. Hence add a dependency on ARCH_MA35, to prevent asking the user
about this driver when configuring a kernel without MA35 SoC support.
Also, do not enable the driver by default when merely compile-testing.
While at it, fix a misspelling of "Nuvoton".
Fixes: e4bb55d6ccf0f774 ("reset: Add Nuvoton ma35d1 reset driver support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/reset/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 0cdf9d64c2185c89..ccd59ddd76100a51 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -144,8 +144,9 @@ config RESET_NPCM
BMC SoCs.
config RESET_NUVOTON_MA35D1
- bool "Nuvton MA35D1 Reset Driver"
- default ARCH_MA35 || COMPILE_TEST
+ bool "Nuvoton MA35D1 Reset Driver"
+ depends on ARCH_MA35 || COMPILE_TEST
+ default ARCH_MA35
help
This enables the reset controller driver for Nuvoton MA35D1 SoC.
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] reset: RESET_NUVOTON_MA35D1 should depend on ARCH_MA35
2023-06-06 9:55 [PATCH] reset: RESET_NUVOTON_MA35D1 should depend on ARCH_MA35 Geert Uytterhoeven
@ 2023-06-06 9:59 ` Ilpo Järvinen
2023-06-06 10:19 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Ilpo Järvinen @ 2023-06-06 9:59 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Philipp Zabel, Arnd Bergmann, Jacky Huang, linux-arm-kernel, LKML
[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]
On Tue, 6 Jun 2023, Geert Uytterhoeven wrote:
> The Nuvoton MA35D1 reset controller is only present on Nuvoton MA35
> SoCs. Hence add a dependency on ARCH_MA35, to prevent asking the user
> about this driver when configuring a kernel without MA35 SoC support.
> Also, do not enable the driver by default when merely compile-testing.
>
> While at it, fix a misspelling of "Nuvoton".
>
> Fixes: e4bb55d6ccf0f774 ("reset: Add Nuvoton ma35d1 reset driver support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/reset/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 0cdf9d64c2185c89..ccd59ddd76100a51 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -144,8 +144,9 @@ config RESET_NPCM
> BMC SoCs.
>
> config RESET_NUVOTON_MA35D1
> - bool "Nuvton MA35D1 Reset Driver"
> - default ARCH_MA35 || COMPILE_TEST
> + bool "Nuvoton MA35D1 Reset Driver"
> + depends on ARCH_MA35 || COMPILE_TEST
> + default ARCH_MA35
> help
> This enables the reset controller driver for Nuvoton MA35D1 SoC.
All adjustments make sense.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] reset: RESET_NUVOTON_MA35D1 should depend on ARCH_MA35
2023-06-06 9:59 ` Ilpo Järvinen
@ 2023-06-06 10:19 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-06-06 10:19 UTC (permalink / raw)
To: Ilpo Järvinen, Geert Uytterhoeven
Cc: Philipp Zabel, Jacky Huang, linux-arm-kernel, LKML
On Tue, Jun 6, 2023, at 11:59, Ilpo Järvinen wrote:
> On Tue, 6 Jun 2023, Geert Uytterhoeven wrote:
>
>> The Nuvoton MA35D1 reset controller is only present on Nuvoton MA35
>> SoCs. Hence add a dependency on ARCH_MA35, to prevent asking the user
>> about this driver when configuring a kernel without MA35 SoC support.
>> Also, do not enable the driver by default when merely compile-testing.
>>
>> While at it, fix a misspelling of "Nuvoton".
>>
>> Fixes: e4bb55d6ccf0f774 ("reset: Add Nuvoton ma35d1 reset driver support")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Applied on top of the initial patch, thanks!
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-06 10:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-06 9:55 [PATCH] reset: RESET_NUVOTON_MA35D1 should depend on ARCH_MA35 Geert Uytterhoeven
2023-06-06 9:59 ` Ilpo Järvinen
2023-06-06 10:19 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®