From: Florian Fainelli <f.fainelli@gmail.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
maxime.ripard@free-electrons.com, wens@csie.org,
linux@armlinux.org.uk, catalin.marinas@arm.com,
will.deacon@arm.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, davem@davemloft.net
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64
Date: Tue, 14 Mar 2017 11:20:31 -0700 [thread overview]
Message-ID: <6fd5818c-94ad-ae1b-2caf-ca657a2f1066@gmail.com> (raw)
In-Reply-To: <20170314141856.24560-17-clabbe.montjoie@gmail.com>
On 03/14/2017 07:18 AM, Corentin Labbe wrote:
> The dwmac-sun8i hardware is present on the pine64
> It uses an external PHY via RMII.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> index c680ed3..b53994d 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
> @@ -109,3 +109,18 @@
> &usbphy {
> status = "okay";
> };
> +
> +&mdio {
> + ext_rmii_phy1: ethernet-phy@1 {
> + reg = <1>;
Even though it's optional, it's nice to have a:
compatible = "ethernet-phy-ieee802.3-c22"
string here.
This applies to all DTS files that you have in subsequent patches.
Thanks!
--
Florian
next prev parent reply other threads:[~2017-03-14 18:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 14:18 [PATCH v2 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 01/20] net-next: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 02/20] net-next: stmmac: add optional setup function Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 03/20] ARM: sun8i: dt: Add DT bindings documentation for Allwinner dwmac-sun8i Corentin Labbe
2017-03-20 22:21 ` Rob Herring
2017-03-14 14:18 ` [PATCH v2 04/20] ARM: sun8i: dt: Add DT bindings documentation for Allwinner syscon Corentin Labbe
2017-03-21 1:08 ` Rob Herring
2017-03-14 14:18 ` [PATCH v2 05/20] net-next: stmmac: Add dwmac-sun8i Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 06/20] ARM: dts: sunxi-h3-h5: Add dt node for the syscon control module Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 07/20] ARM: dts: sunxi-h3-h5: add dwmac-sun8i ethernet driver Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 08/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Banana Pi M2+ Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 09/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange PI PC Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 10/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange Pi 2 Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 11/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange PI One Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 12/20] ARM: dts: sun8i: Enable dwmac-sun8i on the Orange Pi plus Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 13/20] ARM: dts: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 14/20] ARM64: dts: sun50i-a64: Add dt node for the syscon control module Corentin Labbe
2017-03-15 11:06 ` Sergei Shtylyov
2017-03-14 14:18 ` [PATCH v2 15/20] ARM64: dts: sun50i-a64: add dwmac-sun8i Ethernet driver Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 16/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64 Corentin Labbe
2017-03-14 18:20 ` Florian Fainelli [this message]
2017-03-14 14:18 ` [PATCH v2 17/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on pine64 plus Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 18/20] ARM: dts: sun50i-a64: enable dwmac-sun8i on the BananaPi M64 Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 19/20] ARM: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig Corentin Labbe
2017-03-14 14:18 ` [PATCH v2 20/20] ARM: sunxi: Enable dwmac-sun8i driver on multi_v7_defconfig Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fd5818c-94ad-ae1b-2caf-ca657a2f1066@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=catalin.marinas@arm.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®