mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Elson Serrao <elson.serrao@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Souradeep Chowdhury <quic_schowdhu@quicinc.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v3 02/10] usb: misc: qcom_eud: add sysfs attribute for port selection
Date: Fri, 13 Mar 2026 13:10:10 +0100	[thread overview]
Message-ID: <6fe7a63c-a1b3-430b-a128-0e38754d6393@oss.qualcomm.com> (raw)
In-Reply-To: <2026031101-cornstalk-partner-a30e@gregkh>

On 3/11/26 2:16 PM, Greg Kroah-Hartman wrote:
> On Mon, Mar 09, 2026 at 01:33:29PM -0700, Elson Serrao wrote:
>> EUD can be mapped to either the primary USB port or the secondary USB port
>> depending on the value of the EUD_PORT_SEL register. Add a 'port' sysfs
>> attribute to allow userspace to select which port EUD should operate on
>> and update the ABI documentation. This is needed for systems with dual
>> USB ports where EUD needs to be accessible on either port depending on the
>> system configuration and use case.
>>
>> Signed-off-by: Elson Serrao <elson.serrao@oss.qualcomm.com>
>> ---
>>  Documentation/ABI/testing/sysfs-driver-eud | 16 ++++++++
>>  drivers/usb/misc/qcom_eud.c                | 43 ++++++++++++++++++++++
>>  2 files changed, 59 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-driver-eud b/Documentation/ABI/testing/sysfs-driver-eud
>> index 2bab0db2d2f0..67223f73ee60 100644
>> --- a/Documentation/ABI/testing/sysfs-driver-eud
>> +++ b/Documentation/ABI/testing/sysfs-driver-eud
>> @@ -7,3 +7,19 @@ Description:
>>  		EUD based on a 1 or a 0 value. By enabling EUD,
>>  		the user is able to activate the mini-usb hub of
>>  		EUD for debug and trace capabilities.
>> +
>> +What:		/sys/bus/platform/drivers/qcom_eud/.../port
>> +Date:		January 2026
>> +Contact:	Elson Serrao <elson.serrao@oss.qualcomm.com>
>> +Description:
>> +		Selects which USB port the Embedded USB Debugger (EUD)
>> +		is mapped to on platforms providing multiple High-Speed
>> +		USB ports.
>> +
>> +		Valid values:
>> +		  0 - Primary USB port
>> +		  1 - Secondary USB port
> 
> Why not use "primary" and "secondary" as values instead?  That makes
> this much simpler to understand.

It's not inconceivable that future iterations of this hardware will let
one mux between more than two USB PHYs/ports (there are already a multitude
of SoCs where we have 4 or more USB controllers and >= that ports)

Konrad

  parent reply	other threads:[~2026-03-13 12:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 20:33 [PATCH RFC v3 00/10] Improve Qualcomm EUD driver and platform support Elson Serrao
2026-03-09 20:33 ` [PATCH RFC v3 01/10] dt-bindings: soc: qcom: eud: Add support for dual-port configuration Elson Serrao
2026-03-09 20:33 ` [PATCH RFC v3 02/10] usb: misc: qcom_eud: add sysfs attribute for port selection Elson Serrao
2026-03-11 13:16   ` Greg Kroah-Hartman
2026-03-11 22:57     ` Elson Serrao
2026-03-13 12:10     ` Konrad Dybcio [this message]
2026-03-13 12:45       ` Greg Kroah-Hartman
2026-03-13 12:50         ` Konrad Dybcio
2026-03-09 20:33 ` [PATCH RFC v3 03/10] usb: misc: qcom_eud: add per-port High-Speed PHY control Elson Serrao
2026-03-09 20:33 ` [PATCH RFC v3 04/10] usb: misc: qcom_eud: add per-port role switch support Elson Serrao
2026-03-09 20:33 ` [PATCH RFC v3 05/10] usb: misc: qcom_eud: improve enable_store API Elson Serrao
2026-03-09 20:33 ` [PATCH RFC v3 06/10] usb: misc: qcom_eud: fix virtual attach/detach event handling Elson Serrao
2026-03-09 20:33 ` [PATCH RFC v3 07/10] usb: misc: qcom_eud: add host mode coordination Elson Serrao
2026-03-09 20:33 ` [PATCH RFC v3 08/10] usb: dwc3: qcom: notify EUD driver of role changes Elson Serrao
2026-03-09 20:33 ` [PATCH RFC v3 09/10] arm64: dts: qcom: kodiak: Fix EUD USB controller connection Elson Serrao
2026-03-09 20:33 ` [PATCH RFC v3 10/10] arm64: dts: qcom: Map USB connector to EUD for kodiak boards Elson Serrao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fe7a63c-a1b3-430b-a128-0e38754d6393@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=elson.serrao@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=quic_schowdhu@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®