[PATCH] security: smack: fix typos and spelling errors

[PATCH] security: smack: fix typos and spelling errors

[Tanya Agarwal]

From: Tanya Agarwal <tanyaagarwal25699@gmail.com>

Fix typos and spelling errors in security/smack module comments that were
identified using the codespell tool.
No functional changes - documentation only.

Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
---
Original discussion:
https://lore.kernel.org/all/20250112072925.1774-1-tanyaagarwal25699@gmail.com

This patch set is split into individual patches for each LSM
to facilitate easier review by respective maintainers.

 security/smack/smack.h        | 2 +-
 security/smack/smack_access.c | 4 ++--
 security/smack/smack_lsm.c    | 6 +++---
 security/smack/smackfs.c      | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/security/smack/smack.h b/security/smack/smack.h
index dbf8d7226eb5..ca38e145f364 100644
--- a/security/smack/smack.h
+++ b/security/smack/smack.h
@@ -42,7 +42,7 @@
 
 /*
  * This is the repository for labels seen so that it is
- * not necessary to keep allocating tiny chuncks of memory
+ * not necessary to keep allocating tiny chunks of memory
  * and so that they can be shared.
  *
  * Labels are never modified in place. Anytime a label
diff --git a/security/smack/smack_access.c b/security/smack/smack_access.c
index 585e5e35710b..5c17aee5dd78 100644
--- a/security/smack/smack_access.c
+++ b/security/smack/smack_access.c
@@ -242,7 +242,7 @@ int smk_tskacc(struct task_smack *tsp, struct smack_known *obj_known,
 	}
 
 	/*
-	 * Allow for priviliged to override policy.
+	 * Allow for privileged to override policy.
 	 */
 	if (rc != 0 && smack_privileged(CAP_MAC_OVERRIDE))
 		rc = 0;
@@ -277,7 +277,7 @@ int smk_curacc(struct smack_known *obj_known,
 
 #ifdef CONFIG_AUDIT
 /**
- * smack_str_from_perm : helper to transalate an int to a
+ * smack_str_from_perm : helper to translate an int to a
  * readable string
  * @string : the string to fill
  * @access : the int
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 0c476282e279..85ec288eefe7 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -1950,7 +1950,7 @@ static int smack_file_send_sigiotask(struct task_struct *tsk,
 	 */
 	file = fown->file;
 
-	/* we don't log here as rc can be overriden */
+	/* we don't log here as rc can be overridden */
 	blob = smack_file(file);
 	skp = *blob;
 	rc = smk_access(skp, tkp, MAY_DELIVER, NULL);
@@ -4211,7 +4211,7 @@ static int smack_socket_sock_rcv_skb(struct sock *sk, struct sk_buff *skb)
 		/*
 		 * Receiving a packet requires that the other end
 		 * be able to write here. Read access is not required.
-		 * This is the simplist possible security model
+		 * This is the simplest possible security model
 		 * for networking.
 		 */
 		rc = smk_access(skp, ssp->smk_in, MAY_WRITE, &ad);
@@ -4717,7 +4717,7 @@ static int smack_post_notification(const struct cred *w_cred,
  * @gfp: type of the memory for the allocation
  *
  * Prepare to audit cases where (@field @op @rulestr) is true.
- * The label to be audited is created if necessay.
+ * The label to be audited is created if necessary.
  */
 static int smack_audit_rule_init(u32 field, u32 op, char *rulestr, void **vrule,
 				 gfp_t gfp)
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index 1401412fd794..432e2d094e35 100644
--- a/security/smack/smackfs.c
+++ b/security/smack/smackfs.c
@@ -165,7 +165,7 @@ static int smk_cipso_doi_value = SMACK_CIPSO_DOI_DEFAULT;
 #define SMK_LOADLEN	(SMK_LABELLEN + SMK_LABELLEN + SMK_ACCESSLEN)
 
 /*
- * Stricly for CIPSO level manipulation.
+ * Strictly for CIPSO level manipulation.
  * Set the category bit number in a smack label sized buffer.
  */
 static inline void smack_catset_bit(unsigned int cat, char *catsetp)
-- 
2.39.5

Re: [PATCH] security: smack: fix typos and spelling errors

[Casey Schaufler]

On 1/23/2025 11:44 AM, Tanya Agarwal wrote:
> From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
>
> Fix typos and spelling errors in security/smack module comments that were
> identified using the codespell tool.
> No functional changes - documentation only.
>
> Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>


Thank you. I will take this in through the Smack tree.

> ---
> Original discussion:
> https://lore.kernel.org/all/20250112072925.1774-1-tanyaagarwal25699@gmail.com
>
> This patch set is split into individual patches for each LSM
> to facilitate easier review by respective maintainers.
>
>  security/smack/smack.h        | 2 +-
>  security/smack/smack_access.c | 4 ++--
>  security/smack/smack_lsm.c    | 6 +++---
>  security/smack/smackfs.c      | 2 +-
>  4 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index dbf8d7226eb5..ca38e145f364 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -42,7 +42,7 @@
>  
>  /*
>   * This is the repository for labels seen so that it is
> - * not necessary to keep allocating tiny chuncks of memory
> + * not necessary to keep allocating tiny chunks of memory
>   * and so that they can be shared.
>   *
>   * Labels are never modified in place. Anytime a label
> diff --git a/security/smack/smack_access.c b/security/smack/smack_access.c
> index 585e5e35710b..5c17aee5dd78 100644
> --- a/security/smack/smack_access.c
> +++ b/security/smack/smack_access.c
> @@ -242,7 +242,7 @@ int smk_tskacc(struct task_smack *tsp, struct smack_known *obj_known,
>  	}
>  
>  	/*
> -	 * Allow for priviliged to override policy.
> +	 * Allow for privileged to override policy.
>  	 */
>  	if (rc != 0 && smack_privileged(CAP_MAC_OVERRIDE))
>  		rc = 0;
> @@ -277,7 +277,7 @@ int smk_curacc(struct smack_known *obj_known,
>  
>  #ifdef CONFIG_AUDIT
>  /**
> - * smack_str_from_perm : helper to transalate an int to a
> + * smack_str_from_perm : helper to translate an int to a
>   * readable string
>   * @string : the string to fill
>   * @access : the int
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 0c476282e279..85ec288eefe7 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -1950,7 +1950,7 @@ static int smack_file_send_sigiotask(struct task_struct *tsk,
>  	 */
>  	file = fown->file;
>  
> -	/* we don't log here as rc can be overriden */
> +	/* we don't log here as rc can be overridden */
>  	blob = smack_file(file);
>  	skp = *blob;
>  	rc = smk_access(skp, tkp, MAY_DELIVER, NULL);
> @@ -4211,7 +4211,7 @@ static int smack_socket_sock_rcv_skb(struct sock *sk, struct sk_buff *skb)
>  		/*
>  		 * Receiving a packet requires that the other end
>  		 * be able to write here. Read access is not required.
> -		 * This is the simplist possible security model
> +		 * This is the simplest possible security model
>  		 * for networking.
>  		 */
>  		rc = smk_access(skp, ssp->smk_in, MAY_WRITE, &ad);
> @@ -4717,7 +4717,7 @@ static int smack_post_notification(const struct cred *w_cred,
>   * @gfp: type of the memory for the allocation
>   *
>   * Prepare to audit cases where (@field @op @rulestr) is true.
> - * The label to be audited is created if necessay.
> + * The label to be audited is created if necessary.
>   */
>  static int smack_audit_rule_init(u32 field, u32 op, char *rulestr, void **vrule,
>  				 gfp_t gfp)
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 1401412fd794..432e2d094e35 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -165,7 +165,7 @@ static int smk_cipso_doi_value = SMACK_CIPSO_DOI_DEFAULT;
>  #define SMK_LOADLEN	(SMK_LABELLEN + SMK_LABELLEN + SMK_ACCESSLEN)
>  
>  /*
> - * Stricly for CIPSO level manipulation.
> + * Strictly for CIPSO level manipulation.
>   * Set the category bit number in a smack label sized buffer.
>   */
>  static inline void smack_catset_bit(unsigned int cat, char *catsetp)

Re: [PATCH] security: smack: fix typos and spelling errors

[Tanya Agarwal]

On Fri, Jan 24, 2025 at 3:06 AM Casey Schaufler <casey@schaufler-ca.com> wrote:
>
> On 1/23/2025 11:44 AM, Tanya Agarwal wrote:
> > From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> >
> > Fix typos and spelling errors in security/smack module comments that were
> > identified using the codespell tool.
> > No functional changes - documentation only.
> >
> > Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> > Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
>
>
> Thank you. I will take this in through the Smack tree.

Thanks, Casey.

Regards,
Tanya

>
> > ---
> > Original discussion:
> > https://lore.kernel.org/all/20250112072925.1774-1-tanyaagarwal25699@gmail.com
> >
> > This patch set is split into individual patches for each LSM
> > to facilitate easier review by respective maintainers.
> >
> >  security/smack/smack.h        | 2 +-
> >  security/smack/smack_access.c | 4 ++--
> >  security/smack/smack_lsm.c    | 6 +++---
> >  security/smack/smackfs.c      | 2 +-
> >  4 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/security/smack/smack.h b/security/smack/smack.h
> > index dbf8d7226eb5..ca38e145f364 100644
> > --- a/security/smack/smack.h
> > +++ b/security/smack/smack.h
> > @@ -42,7 +42,7 @@
> >
> >  /*
> >   * This is the repository for labels seen so that it is
> > - * not necessary to keep allocating tiny chuncks of memory
> > + * not necessary to keep allocating tiny chunks of memory
> >   * and so that they can be shared.
> >   *
> >   * Labels are never modified in place. Anytime a label
> > diff --git a/security/smack/smack_access.c b/security/smack/smack_access.c
> > index 585e5e35710b..5c17aee5dd78 100644
> > --- a/security/smack/smack_access.c
> > +++ b/security/smack/smack_access.c
> > @@ -242,7 +242,7 @@ int smk_tskacc(struct task_smack *tsp, struct smack_known *obj_known,
> >       }
> >
> >       /*
> > -      * Allow for priviliged to override policy.
> > +      * Allow for privileged to override policy.
> >        */
> >       if (rc != 0 && smack_privileged(CAP_MAC_OVERRIDE))
> >               rc = 0;
> > @@ -277,7 +277,7 @@ int smk_curacc(struct smack_known *obj_known,
> >
> >  #ifdef CONFIG_AUDIT
> >  /**
> > - * smack_str_from_perm : helper to transalate an int to a
> > + * smack_str_from_perm : helper to translate an int to a
> >   * readable string
> >   * @string : the string to fill
> >   * @access : the int
> > diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> > index 0c476282e279..85ec288eefe7 100644
> > --- a/security/smack/smack_lsm.c
> > +++ b/security/smack/smack_lsm.c
> > @@ -1950,7 +1950,7 @@ static int smack_file_send_sigiotask(struct task_struct *tsk,
> >        */
> >       file = fown->file;
> >
> > -     /* we don't log here as rc can be overriden */
> > +     /* we don't log here as rc can be overridden */
> >       blob = smack_file(file);
> >       skp = *blob;
> >       rc = smk_access(skp, tkp, MAY_DELIVER, NULL);
> > @@ -4211,7 +4211,7 @@ static int smack_socket_sock_rcv_skb(struct sock *sk, struct sk_buff *skb)
> >               /*
> >                * Receiving a packet requires that the other end
> >                * be able to write here. Read access is not required.
> > -              * This is the simplist possible security model
> > +              * This is the simplest possible security model
> >                * for networking.
> >                */
> >               rc = smk_access(skp, ssp->smk_in, MAY_WRITE, &ad);
> > @@ -4717,7 +4717,7 @@ static int smack_post_notification(const struct cred *w_cred,
> >   * @gfp: type of the memory for the allocation
> >   *
> >   * Prepare to audit cases where (@field @op @rulestr) is true.
> > - * The label to be audited is created if necessay.
> > + * The label to be audited is created if necessary.
> >   */
> >  static int smack_audit_rule_init(u32 field, u32 op, char *rulestr, void **vrule,
> >                                gfp_t gfp)
> > diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> > index 1401412fd794..432e2d094e35 100644
> > --- a/security/smack/smackfs.c
> > +++ b/security/smack/smackfs.c
> > @@ -165,7 +165,7 @@ static int smk_cipso_doi_value = SMACK_CIPSO_DOI_DEFAULT;
> >  #define SMK_LOADLEN  (SMK_LABELLEN + SMK_LABELLEN + SMK_ACCESSLEN)
> >
> >  /*
> > - * Stricly for CIPSO level manipulation.
> > + * Strictly for CIPSO level manipulation.
> >   * Set the category bit number in a smack label sized buffer.
> >   */
> >  static inline void smack_catset_bit(unsigned int cat, char *catsetp)