* [PATCH] [ARM] Fix condition in arm_elf_read_implies_exec() to set READ_IMPLIES_EXEC
@ 2009-02-05 17:29 Makito SHIOKAWA
2009-02-06 2:41 ` Makito SHIOKAWA
0 siblings, 1 reply; 2+ messages in thread
From: Makito SHIOKAWA @ 2009-02-05 17:29 UTC (permalink / raw)
To: linux-kernel
READ_IMPLIES_EXEC must be set when binary _is an executable stack_
(i.e. not EXSTACK_DISABLE_X).
Signed-off-by: Makito SHIOKAWA <lkhmkt@gmail.com>
---
arch/arm/kernel/elf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/arm/kernel/elf.c
+++ b/arch/arm/kernel/elf.c
@@ -74,7 +74,7 @@ EXPORT_SYMBOL(elf_set_personality);
*/
int arm_elf_read_implies_exec(const struct elf32_hdr *x, int executable_stack)
{
- if (executable_stack != EXSTACK_ENABLE_X)
+ if (executable_stack != EXSTACK_DISABLE_X)
return 1;
if (cpu_architecture() <= CPU_ARCH_ARMv6)
return 1;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [ARM] Fix condition in arm_elf_read_implies_exec() to set READ_IMPLIES_EXEC
2009-02-05 17:29 [PATCH] [ARM] Fix condition in arm_elf_read_implies_exec() to set READ_IMPLIES_EXEC Makito SHIOKAWA
@ 2009-02-06 2:41 ` Makito SHIOKAWA
0 siblings, 0 replies; 2+ messages in thread
From: Makito SHIOKAWA @ 2009-02-06 2:41 UTC (permalink / raw)
To: linux-kernel
Additionally, XN bit seems to be supported from ARMv6.
Signed-off-by: Makito SHIOKAWA <lkhmkt@gmail.com>
---
arch/arm/kernel/elf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/arch/arm/kernel/elf.c
+++ b/arch/arm/kernel/elf.c
@@ -74,9 +74,9 @@ EXPORT_SYMBOL(elf_set_personality);
*/
int arm_elf_read_implies_exec(const struct elf32_hdr *x, int executable_stack)
{
- if (executable_stack != EXSTACK_ENABLE_X)
+ if (executable_stack != EXSTACK_DISABLE_X)
return 1;
- if (cpu_architecture() <= CPU_ARCH_ARMv6)
+ if (cpu_architecture() < CPU_ARCH_ARMv6)
return 1;
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-06 2:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-05 17:29 [PATCH] [ARM] Fix condition in arm_elf_read_implies_exec() to set READ_IMPLIES_EXEC Makito SHIOKAWA
2009-02-06 2:41 ` Makito SHIOKAWA
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®