From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
To: Zhen Lei <thunder.leizhen@huawei.com>,
Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Andrew Morton <akpm@osdl.org>,
linux-um <linux-um@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] um: fix error return code in slip_open()
Date: Sat, 8 May 2021 10:13:02 +0100 [thread overview]
Message-ID: <70835fd6-69ba-8bff-65a1-aad83e400a52@cambridgegreys.com> (raw)
In-Reply-To: <20210508031354.2127-1-thunder.leizhen@huawei.com>
On 08/05/2021 04:13, Zhen Lei wrote:
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
>
> Fixes: a3c77c67a443 ("[PATCH] uml: slirp and slip driver cleanups and fixes")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> arch/um/drivers/slip_user.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/um/drivers/slip_user.c b/arch/um/drivers/slip_user.c
> index 482a19c5105c..7334019c9e60 100644
> --- a/arch/um/drivers/slip_user.c
> +++ b/arch/um/drivers/slip_user.c
> @@ -145,7 +145,8 @@ static int slip_open(void *data)
> }
> sfd = err;
>
> - if (set_up_tty(sfd))
> + err = set_up_tty(sfd);
> + if (err)
> goto out_close2;
>
> pri->slave = sfd;
>
Acked-By: anton.ivanov@cambridgegreys.com
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
prev parent reply other threads:[~2021-05-08 9:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 3:13 Zhen Lei
2021-05-08 9:13 ` Anton Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70835fd6-69ba-8bff-65a1-aad83e400a52@cambridgegreys.com \
--to=anton.ivanov@cambridgegreys.com \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®