From: John Garry <john.garry@linux.dev>
To: Laurence Oberman <loberman@redhat.com>,
"Martin K . Petersen" <mkp@kernel.org>,
linux-scsi@vger.kernel.org
Cc: "James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
Bart Van Assche <bvanassche@acm.org>,
Martin Wilck <mwilck@suse.com>, Hannes Reinecke <hare@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] scsi: scsi_dh_alua: set handler_data before alua_initialize()
Date: Mon, 16 Nov 2026 08:44:48 +0000 [thread overview]
Message-ID: <70e9dc89-595b-4cab-a338-f0a1b6b9b58a@linux.dev> (raw)
In-Reply-To: <57f9665fb8c3571cff55b2fafceec7437634fd5d.camel@redhat.com>
On 11/15/26 19:37, Laurence Oberman wrote:
> Agreed, group_id is never read or written. All other members are
> initialized before handler_data is set (h is kzalloc'd, and disabled
> is set under init_mutex in alua_initialize()).
>
> I would prefer to keep this patch minimal since it is tagged for
> stable, and send a follow-up cleanup that drops the now-redundant
> h check in alua_rtpg_queue() and removes the unused group_id member.
> Does that work for you, or would you rather I fold both into a v2?
I think that you can keep it separate.
Thanks,
John
next prev parent reply other threads:[~2026-11-16 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 20:11 Laurence Oberman
2026-11-11 11:14 ` Martin Wilck
2026-11-15 18:04 ` John Garry
2026-11-15 19:37 ` Laurence Oberman
2026-11-16 8:44 ` John Garry [this message]
2026-11-16 9:32 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70e9dc89-595b-4cab-a338-f0a1b6b9b58a@linux.dev \
--to=john.garry@linux.dev \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=hare@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=mkp@kernel.org \
--cc=mwilck@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®