* Re: [PATCH v6 2/2] selftests: tmpfs: Add kselftest support to tmpfs
[not found] ` <20241219152929.4005003-3-cvam0000@gmail.com>
@ 2024-12-20 16:46 ` Shuah
0 siblings, 0 replies; only message in thread
From: Shuah @ 2024-12-20 16:46 UTC (permalink / raw)
To: Shivam Chaudhary; +Cc: linux-kselftest, linux-kernel, shuah
On 12/19/24 08:29, Shivam Chaudhary wrote:
> Replace direct error handling with 'ksft_test_result_*'
> macros for better reporting.
>
> Test logs:
>
> Before change:
> - Without root
> error: unshare, errno 1
>
> - With root
> No, output
>
> After change:
> - Without root
> TAP version 13
> 1..1
> ok 2 # SKIP This test needs root to run!
> Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0
>
> - With root
> TAP version 13
> 1..1
> ok 1 Test : Success
> Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> Signed-off-by: Shivam Chaudhary <cvam0000@gmail.com>
> ---
> .../selftests/tmpfs/bug-link-o-tmpfile.c | 29 ++++++++++---------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c b/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c
> index 657b64857e82..91b30a0ca365 100644
> --- a/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c
> +++ b/tools/testing/selftests/tmpfs/bug-link-o-tmpfile.c
> @@ -41,39 +41,40 @@ int main(void)
>
> if (unshare(CLONE_NEWNS) == -1) {
> if (errno == ENOSYS || errno == EPERM) {
> - fprintf(stderr, "error: unshare, errno %d\n", errno);
> - return 4;
> + ksft_test_result_skip("unshare() error: unshare, errno %d\n", errno);
ksft_exit_skip_msg() is a better choice here.
The rest looks good.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] only message in thread