* [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes
@ 2024-02-15 10:54 MD Danish Anwar
2024-02-15 14:26 ` Andrew Davis
2024-02-15 15:57 ` Roger Quadros
0 siblings, 2 replies; 6+ messages in thread
From: MD Danish Anwar @ 2024-02-15 10:54 UTC (permalink / raw)
To: Vignesh Raghavendra, Nishanth Menon
Cc: Andrew Lunn, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
linux-kernel, devicetree, linux-arm-kernel, Tero Kristo, srk,
r-gunasekaran, Roger Quadros, MD Danish Anwar
Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
property is no longer used by ICSSG driver.
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
arch/arm64/boot/dts/ti/k3-am654-idk.dtso | 4 ----
2 files changed, 6 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
index 0a6e75265ba9..bb0e29873df7 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
@@ -68,7 +68,6 @@ icssg2_emac0: port@0 {
reg = <0>;
phy-handle = <&icssg2_phy0>;
phy-mode = "rgmii-id";
- ti,syscon-rgmii-delay = <&scm_conf 0x4120>;
/* Filled in by bootloader */
local-mac-address = [00 00 00 00 00 00];
};
@@ -76,7 +75,6 @@ icssg2_emac1: port@1 {
reg = <1>;
phy-handle = <&icssg2_phy1>;
phy-mode = "rgmii-id";
- ti,syscon-rgmii-delay = <&scm_conf 0x4124>;
/* Filled in by bootloader */
local-mac-address = [00 00 00 00 00 00];
};
diff --git a/arch/arm64/boot/dts/ti/k3-am654-idk.dtso b/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
index 8bdb87fcbde0..d4bc80032587 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
@@ -72,7 +72,6 @@ icssg0_emac0: port@0 {
reg = <0>;
phy-handle = <&icssg0_phy0>;
phy-mode = "rgmii-id";
- ti,syscon-rgmii-delay = <&scm_conf 0x4100>;
/* Filled in by bootloader */
local-mac-address = [00 00 00 00 00 00];
};
@@ -80,7 +79,6 @@ icssg0_emac1: port@1 {
reg = <1>;
phy-handle = <&icssg0_phy1>;
phy-mode = "rgmii-id";
- ti,syscon-rgmii-delay = <&scm_conf 0x4104>;
/* Filled in by bootloader */
local-mac-address = [00 00 00 00 00 00];
};
@@ -140,7 +138,6 @@ icssg1_emac0: port@0 {
reg = <0>;
phy-handle = <&icssg1_phy0>;
phy-mode = "rgmii-id";
- ti,syscon-rgmii-delay = <&scm_conf 0x4110>;
/* Filled in by bootloader */
local-mac-address = [00 00 00 00 00 00];
};
@@ -148,7 +145,6 @@ icssg1_emac1: port@1 {
reg = <1>;
phy-handle = <&icssg1_phy1>;
phy-mode = "rgmii-id";
- ti,syscon-rgmii-delay = <&scm_conf 0x4114>;
/* Filled in by bootloader */
local-mac-address = [00 00 00 00 00 00];
};
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes
2024-02-15 10:54 [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes MD Danish Anwar
@ 2024-02-15 14:26 ` Andrew Davis
2024-02-15 15:57 ` Roger Quadros
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Davis @ 2024-02-15 14:26 UTC (permalink / raw)
To: MD Danish Anwar, Vignesh Raghavendra, Nishanth Menon
Cc: Andrew Lunn, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
linux-kernel, devicetree, linux-arm-kernel, Tero Kristo, srk,
r-gunasekaran, Roger Quadros
On 2/15/24 4:54 AM, MD Danish Anwar wrote:
> Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
> property is no longer used by ICSSG driver.
>
I see a couple more instances in k3-am65-iot2050-common.dtsi.
Andrew
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
> arch/arm64/boot/dts/ti/k3-am654-idk.dtso | 4 ----
> 2 files changed, 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
> index 0a6e75265ba9..bb0e29873df7 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
> @@ -68,7 +68,6 @@ icssg2_emac0: port@0 {
> reg = <0>;
> phy-handle = <&icssg2_phy0>;
> phy-mode = "rgmii-id";
> - ti,syscon-rgmii-delay = <&scm_conf 0x4120>;
> /* Filled in by bootloader */
> local-mac-address = [00 00 00 00 00 00];
> };
> @@ -76,7 +75,6 @@ icssg2_emac1: port@1 {
> reg = <1>;
> phy-handle = <&icssg2_phy1>;
> phy-mode = "rgmii-id";
> - ti,syscon-rgmii-delay = <&scm_conf 0x4124>;
> /* Filled in by bootloader */
> local-mac-address = [00 00 00 00 00 00];
> };
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-idk.dtso b/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
> index 8bdb87fcbde0..d4bc80032587 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
> @@ -72,7 +72,6 @@ icssg0_emac0: port@0 {
> reg = <0>;
> phy-handle = <&icssg0_phy0>;
> phy-mode = "rgmii-id";
> - ti,syscon-rgmii-delay = <&scm_conf 0x4100>;
> /* Filled in by bootloader */
> local-mac-address = [00 00 00 00 00 00];
> };
> @@ -80,7 +79,6 @@ icssg0_emac1: port@1 {
> reg = <1>;
> phy-handle = <&icssg0_phy1>;
> phy-mode = "rgmii-id";
> - ti,syscon-rgmii-delay = <&scm_conf 0x4104>;
> /* Filled in by bootloader */
> local-mac-address = [00 00 00 00 00 00];
> };
> @@ -140,7 +138,6 @@ icssg1_emac0: port@0 {
> reg = <0>;
> phy-handle = <&icssg1_phy0>;
> phy-mode = "rgmii-id";
> - ti,syscon-rgmii-delay = <&scm_conf 0x4110>;
> /* Filled in by bootloader */
> local-mac-address = [00 00 00 00 00 00];
> };
> @@ -148,7 +145,6 @@ icssg1_emac1: port@1 {
> reg = <1>;
> phy-handle = <&icssg1_phy1>;
> phy-mode = "rgmii-id";
> - ti,syscon-rgmii-delay = <&scm_conf 0x4114>;
> /* Filled in by bootloader */
> local-mac-address = [00 00 00 00 00 00];
> };
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes
2024-02-15 10:54 [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes MD Danish Anwar
2024-02-15 14:26 ` Andrew Davis
@ 2024-02-15 15:57 ` Roger Quadros
2024-02-15 16:56 ` Anwar, Md Danish
1 sibling, 1 reply; 6+ messages in thread
From: Roger Quadros @ 2024-02-15 15:57 UTC (permalink / raw)
To: MD Danish Anwar, Vignesh Raghavendra, Nishanth Menon
Cc: Andrew Lunn, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
linux-kernel, devicetree, linux-arm-kernel, Tero Kristo, srk,
r-gunasekaran
On 15/02/2024 12:54, MD Danish Anwar wrote:
> Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
> property is no longer used by ICSSG driver.
>
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
> arch/arm64/boot/dts/ti/k3-am654-idk.dtso | 4 ----
> 2 files changed, 6 deletions(-)
What about the DT binding document?
--
cheers,
-roger
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes
2024-02-15 15:57 ` Roger Quadros
@ 2024-02-15 16:56 ` Anwar, Md Danish
2024-02-15 17:23 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: Anwar, Md Danish @ 2024-02-15 16:56 UTC (permalink / raw)
To: Roger Quadros, MD Danish Anwar, Vignesh Raghavendra, Nishanth Menon
Cc: Andrew Lunn, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
linux-kernel, devicetree, linux-arm-kernel, Tero Kristo, srk,
r-gunasekaran
On 2/15/2024 9:27 PM, Roger Quadros wrote:
>
>
> On 15/02/2024 12:54, MD Danish Anwar wrote:
>> Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
>> property is no longer used by ICSSG driver.
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
>> arch/arm64/boot/dts/ti/k3-am654-idk.dtso | 4 ----
>> 2 files changed, 6 deletions(-)
>
> What about the DT binding document?
>
Now I am only removing the property from device tree. Once this proprty
is removed from all DTs, in the 6.9-rc-1 I will remove the binding as
well so that net people can merge that without getting any errors /
warnings.
--
Thanks and Regards,
Md Danish Anwar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes
2024-02-15 16:56 ` Anwar, Md Danish
@ 2024-02-15 17:23 ` Andrew Lunn
2024-02-15 17:33 ` Anwar, Md Danish
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2024-02-15 17:23 UTC (permalink / raw)
To: Anwar, Md Danish
Cc: Roger Quadros, MD Danish Anwar, Vignesh Raghavendra,
Nishanth Menon, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
linux-kernel, devicetree, linux-arm-kernel, Tero Kristo, srk,
r-gunasekaran
On Thu, Feb 15, 2024 at 10:26:59PM +0530, Anwar, Md Danish wrote:
>
>
> On 2/15/2024 9:27 PM, Roger Quadros wrote:
> >
> >
> > On 15/02/2024 12:54, MD Danish Anwar wrote:
> >> Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
> >> property is no longer used by ICSSG driver.
> >>
> >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> >> ---
> >> arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
> >> arch/arm64/boot/dts/ti/k3-am654-idk.dtso | 4 ----
> >> 2 files changed, 6 deletions(-)
> >
> > What about the DT binding document?
> >
>
> Now I am only removing the property from device tree. Once this proprty
> is removed from all DTs, in the 6.9-rc-1 I will remove the binding as
> well so that net people can merge that without getting any errors /
> warnings.
Did the binding have the property as mandatory? If so you are probably
doing this the wrong way around. You should first modify the binding
to mark it as optional and deprecated. Then modify the .dts{i} files
to remove it.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes
2024-02-15 17:23 ` Andrew Lunn
@ 2024-02-15 17:33 ` Anwar, Md Danish
0 siblings, 0 replies; 6+ messages in thread
From: Anwar, Md Danish @ 2024-02-15 17:33 UTC (permalink / raw)
To: Andrew Lunn
Cc: Roger Quadros, MD Danish Anwar, Vignesh Raghavendra,
Nishanth Menon, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
linux-kernel, devicetree, linux-arm-kernel, Tero Kristo, srk,
r-gunasekaran
On 2/15/2024 10:53 PM, Andrew Lunn wrote:
> On Thu, Feb 15, 2024 at 10:26:59PM +0530, Anwar, Md Danish wrote:
>>
>>
>> On 2/15/2024 9:27 PM, Roger Quadros wrote:
>>>
>>>
>>> On 15/02/2024 12:54, MD Danish Anwar wrote:
>>>> Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
>>>> property is no longer used by ICSSG driver.
>>>>
>>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>>> ---
>>>> arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
>>>> arch/arm64/boot/dts/ti/k3-am654-idk.dtso | 4 ----
>>>> 2 files changed, 6 deletions(-)
>>>
>>> What about the DT binding document?
>>>
>>
>> Now I am only removing the property from device tree. Once this proprty
>> is removed from all DTs, in the 6.9-rc-1 I will remove the binding as
>> well so that net people can merge that without getting any errors /
>> warnings.
>
> Did the binding have the property as mandatory? If so you are probably
> doing this the wrong way around. You should first modify the binding
> to mark it as optional and deprecated. Then modify the .dts{i} files
> to remove it.
>
No the binding is optional that is why I am removing this property from
DTs first.
> Andrew
--
Thanks and Regards,
Md Danish Anwar
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-15 17:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-15 10:54 [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes MD Danish Anwar
2024-02-15 14:26 ` Andrew Davis
2024-02-15 15:57 ` Roger Quadros
2024-02-15 16:56 ` Anwar, Md Danish
2024-02-15 17:23 ` Andrew Lunn
2024-02-15 17:33 ` Anwar, Md Danish
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®