From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Arnd Bergmann <arnd@kernel.org>, Oded Gabbay <ogabbay@kernel.org>,
"Jacek Lawrynowicz" <jacek.lawrynowicz@linux.intel.com>,
"Pranjal Ramajor Asha Kanojiya" <quic_pkanojiy@quicinc.com>,
Carl Vanderlip <quic_carlv@quicinc.com>
Cc: Arnd Bergmann <arnd@arndb.de>, <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] accel/qaic: mark debugfs stub functions as static inline
Date: Fri, 12 Apr 2024 09:56:47 -0600 [thread overview]
Message-ID: <71da620b-d590-282a-0e27-2d6fa2902e6e@quicinc.com> (raw)
In-Reply-To: <20240409133945.2976190-1-arnd@kernel.org>
On 4/9/2024 7:39 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The alternative stub functions are listed as global, which produces
> a build failure in some configs:
>
> In file included from drivers/accel/qaic/qaic_drv.c:31:
> drivers/accel/qaic/qaic_debugfs.h:16:5: error: no previous prototype for 'qaic_bootlog_register' [-Werror=missing-prototypes]
> 16 | int qaic_bootlog_register(void) { return 0; }
> | ^~~~~~~~~~~~~~~~~~~~~
> drivers/accel/qaic/qaic_debugfs.h:17:6: error: no previous prototype for 'qaic_bootlog_unregister' [-Werror=missing-prototypes]
> 17 | void qaic_bootlog_unregister(void) {}
> | ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/accel/qaic/qaic_debugfs.h:18:6: error: no previous prototype for 'qaic_debugfs_init' [-Werror=missing-prototypes]
> 18 | void qaic_debugfs_init(struct qaic_drm_device *qddev) {}
> | ^~~~~~~~~~~~~~~~~
>
> Make them static inline as intended.
>
> Fixes: 5f8df5c6def6 ("accel/qaic: Add bootlog debugfs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Pushed to drm-misc-next
-Jeff
prev parent reply other threads:[~2024-04-12 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 13:39 Arnd Bergmann
2024-04-12 15:52 ` Jeffrey Hugo
2024-04-12 15:56 ` Jeffrey Hugo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71da620b-d590-282a-0e27-2d6fa2902e6e@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_carlv@quicinc.com \
--cc=quic_pkanojiy@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®