From: "Yu Kuai" <yukuai@fnnas.com>
To: "shechenglong" <shechenglong@xfusion.com>, <tj@kernel.org>,
<josef@toxicpanda.com>, <axboe@kernel.dk>
Cc: <cgroups@vger.kernel.org>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stone.xulei@xfusion.com>,
<chenjialong@xfusion.com>, <yukuai@fnnas.com>
Subject: Re: [PATCH] block: fix aux stat accumulation destination
Date: Fri, 26 Dec 2025 00:44:37 +0800 [thread overview]
Message-ID: <71df89fb-1766-40d5-8dd5-5d0c6f49519e@fnnas.com> (raw)
In-Reply-To: <20251222021937.1280-1-shechenglong@xfusion.com>
Hi,
在 2025/12/22 10:19, shechenglong 写道:
> Route bfqg_stats_add_aux() time accumulation into the destination
> stats object instead of the source, aligning with other stat fields.
>
> Signed-off-by: shechenglong <shechenglong@xfusion.com>
> ---
> block/bfq-cgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please change the title and follow existing prefix:
block, bfq: fix aux stat accumulation destination
Otherwise, feel free to add:
Reviewed-by: Yu Kuai <yukuai@fnnas.com>
>
> diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
> index 9fb9f3533150..6a75fe1c7a5c 100644
> --- a/block/bfq-cgroup.c
> +++ b/block/bfq-cgroup.c
> @@ -380,7 +380,7 @@ static void bfqg_stats_add_aux(struct bfqg_stats *to, struct bfqg_stats *from)
> blkg_rwstat_add_aux(&to->merged, &from->merged);
> blkg_rwstat_add_aux(&to->service_time, &from->service_time);
> blkg_rwstat_add_aux(&to->wait_time, &from->wait_time);
> - bfq_stat_add_aux(&from->time, &from->time);
> + bfq_stat_add_aux(&to->time, &from->time);
> bfq_stat_add_aux(&to->avg_queue_size_sum, &from->avg_queue_size_sum);
> bfq_stat_add_aux(&to->avg_queue_size_samples,
> &from->avg_queue_size_samples);
--
Thansk,
Kuai
next prev parent reply other threads:[~2025-12-25 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 2:19 shechenglong
2025-12-25 16:44 ` Yu Kuai [this message]
2025-12-28 13:04 ` [PATCH v2 0/1] block,bfq: " shechenglong
2025-12-28 13:04 ` [PATCH v2 1/1] " shechenglong
2025-12-28 16:07 ` [PATCH v2 0/1] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71df89fb-1766-40d5-8dd5-5d0c6f49519e@fnnas.com \
--to=yukuai@fnnas.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=chenjialong@xfusion.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shechenglong@xfusion.com \
--cc=stone.xulei@xfusion.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®