From: "Ziyang Xuan (William)" <william.xuanziyang@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ap420073@gmail.com>
Subject: Re: [PATCH net] macsec: fix UAF bug for real_dev
Date: Tue, 31 May 2022 14:27:53 +0800 [thread overview]
Message-ID: <71f44378-3961-b751-1ae9-f9c4bc4b061a@huawei.com> (raw)
In-Reply-To: <20220530212338.7a7d4145@kernel.org>
> On Sat, 28 May 2022 17:36:59 +0800 Ziyang Xuan wrote:
>> --- a/drivers/net/macsec.c
>> +++ b/drivers/net/macsec.c
>> @@ -107,6 +107,7 @@ struct pcpu_secy_stats {
>> struct macsec_dev {
>> struct macsec_secy secy;
>> struct net_device *real_dev;
>> + netdevice_tracker dev_tracker;
>
> You need to add kdoc for @dev_tracker.
Yes, it's right. I will give v2 later.
Thank you!
> .
>
prev parent reply other threads:[~2022-05-31 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 9:36 Ziyang Xuan
2022-05-31 4:23 ` Jakub Kicinski
2022-05-31 6:27 ` Ziyang Xuan (William) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71f44378-3961-b751-1ae9-f9c4bc4b061a@huawei.com \
--to=william.xuanziyang@huawei.com \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®