mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Xin Gao <gaoxin@cdjrlc.com>, <perex@perex.cz>, <tiwai@suse.com>
Cc: <fred.oh@linux.intel.com>, <akihiko.odaki@gmail.com>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC:do not initialise statics to 0.
Date: Wed, 20 Jul 2022 22:09:27 +0200	[thread overview]
Message-ID: <71f92970-1e76-ed47-e878-d66f747aec86@intel.com> (raw)
In-Reply-To: <20220720195809.9470-1-gaoxin@cdjrlc.com>

On 2022-07-20 9:58 PM, Xin Gao wrote:
> do not initialise statics to 0.

Hello,

Please do not repeat the title in the commit message - brings no value.
Also, the spelling isn't correct - s/initialise/initialize/.

I'd suggest to adhere to title formatting common to given subsystem. git 
log should help you understand which scopes should be part of commit 
title for changes targeting Intel code in ASoC domain. Last but not 
least, title is not a sentence - drop the full stop at the end of it.


Regards,
Czarek

> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>   sound/soc/intel/boards/cht_bsw_rt5645.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/boards/cht_bsw_rt5645.c b/sound/soc/intel/boards/cht_bsw_rt5645.c
> index 45c301ea5e00..8a8b25589c55 100644
> --- a/sound/soc/intel/boards/cht_bsw_rt5645.c
> +++ b/sound/soc/intel/boards/cht_bsw_rt5645.c
> @@ -50,7 +50,7 @@ struct cht_mc_private {
>   #define CHT_RT5645_SSP0_AIF2     BIT(18)
>   #define CHT_RT5645_PMC_PLT_CLK_0 BIT(19)
>   
> -static unsigned long cht_rt5645_quirk = 0;
> +static unsigned long cht_rt5645_quirk;
>   
>   static void log_quirks(struct device *dev)
>   {

      reply	other threads:[~2022-07-20 20:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 19:58 Xin Gao
2022-07-20 20:09 ` Cezary Rojewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71f92970-1e76-ed47-e878-d66f747aec86@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=akihiko.odaki@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=fred.oh@linux.intel.com \
    --cc=gaoxin@cdjrlc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®