* [PATCH] ASoC:do not initialise statics to 0.
@ 2022-07-20 19:58 Xin Gao
2022-07-20 20:09 ` Cezary Rojewski
0 siblings, 1 reply; 2+ messages in thread
From: Xin Gao @ 2022-07-20 19:58 UTC (permalink / raw)
To: perex, tiwai; +Cc: fred.oh, akihiko.odaki, alsa-devel, linux-kernel, Xin Gao
do not initialise statics to 0.
Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
sound/soc/intel/boards/cht_bsw_rt5645.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/cht_bsw_rt5645.c b/sound/soc/intel/boards/cht_bsw_rt5645.c
index 45c301ea5e00..8a8b25589c55 100644
--- a/sound/soc/intel/boards/cht_bsw_rt5645.c
+++ b/sound/soc/intel/boards/cht_bsw_rt5645.c
@@ -50,7 +50,7 @@ struct cht_mc_private {
#define CHT_RT5645_SSP0_AIF2 BIT(18)
#define CHT_RT5645_PMC_PLT_CLK_0 BIT(19)
-static unsigned long cht_rt5645_quirk = 0;
+static unsigned long cht_rt5645_quirk;
static void log_quirks(struct device *dev)
{
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC:do not initialise statics to 0.
2022-07-20 19:58 [PATCH] ASoC:do not initialise statics to 0 Xin Gao
@ 2022-07-20 20:09 ` Cezary Rojewski
0 siblings, 0 replies; 2+ messages in thread
From: Cezary Rojewski @ 2022-07-20 20:09 UTC (permalink / raw)
To: Xin Gao, perex, tiwai; +Cc: fred.oh, akihiko.odaki, alsa-devel, linux-kernel
On 2022-07-20 9:58 PM, Xin Gao wrote:
> do not initialise statics to 0.
Hello,
Please do not repeat the title in the commit message - brings no value.
Also, the spelling isn't correct - s/initialise/initialize/.
I'd suggest to adhere to title formatting common to given subsystem. git
log should help you understand which scopes should be part of commit
title for changes targeting Intel code in ASoC domain. Last but not
least, title is not a sentence - drop the full stop at the end of it.
Regards,
Czarek
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> sound/soc/intel/boards/cht_bsw_rt5645.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/cht_bsw_rt5645.c b/sound/soc/intel/boards/cht_bsw_rt5645.c
> index 45c301ea5e00..8a8b25589c55 100644
> --- a/sound/soc/intel/boards/cht_bsw_rt5645.c
> +++ b/sound/soc/intel/boards/cht_bsw_rt5645.c
> @@ -50,7 +50,7 @@ struct cht_mc_private {
> #define CHT_RT5645_SSP0_AIF2 BIT(18)
> #define CHT_RT5645_PMC_PLT_CLK_0 BIT(19)
>
> -static unsigned long cht_rt5645_quirk = 0;
> +static unsigned long cht_rt5645_quirk;
>
> static void log_quirks(struct device *dev)
> {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-20 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 19:58 [PATCH] ASoC:do not initialise statics to 0 Xin Gao
2022-07-20 20:09 ` Cezary Rojewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®