From: Florian Fainelli <f.fainelli@gmail.com>
To: Zou Wei <zou_wei@huawei.com>,
alcooperx@gmail.com, gregkh@linuxfoundation.org,
f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com
Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v2] usb: Mark sync_all_pins() with static keyword
Date: Fri, 30 Oct 2020 18:54:06 -0700 [thread overview]
Message-ID: <71fd1c46-a674-a3a8-666c-d4240a866470@gmail.com> (raw)
In-Reply-To: <1604108889-15205-1-git-send-email-zou_wei@huawei.com>
On 10/30/2020 6:48 PM, Zou Wei wrote:
> Fix the following sparse warning:
>
> ./brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?
>
> The sync_all_pins has only call site within brcmstb-usb-pinmap.c
> Mark it static as suggested.
>
> Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals")
Not sure if the Fixes: tag is entirely appropriate here, but sure, why not.
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
prev parent reply other threads:[~2020-10-31 1:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 1:48 Zou Wei
2020-10-31 1:54 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71fd1c46-a674-a3a8-666c-d4240a866470@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®