* [PATCH -next v2] usb: Mark sync_all_pins() with static keyword
@ 2020-10-31 1:48 Zou Wei
2020-10-31 1:54 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2020-10-31 1:48 UTC (permalink / raw)
To: alcooperx, gregkh, f.fainelli, bcm-kernel-feedback-list
Cc: linux-usb, linux-arm-kernel, linux-kernel, Zou Wei
Fix the following sparse warning:
./brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?
The sync_all_pins has only call site within brcmstb-usb-pinmap.c
Mark it static as suggested.
Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
v2:
- Make title more precise.
- Shorten the warning path.
- Add period.
drivers/usb/misc/brcmstb-usb-pinmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c
index 02144c3..cc9618d 100644
--- a/drivers/usb/misc/brcmstb-usb-pinmap.c
+++ b/drivers/usb/misc/brcmstb-usb-pinmap.c
@@ -216,7 +216,7 @@ static int parse_pins(struct device *dev, struct device_node *dn,
return 0;
}
-void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
+static void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
{
struct out_pin *pout;
struct in_pin *pin;
--
2.6.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next v2] usb: Mark sync_all_pins() with static keyword
2020-10-31 1:48 [PATCH -next v2] usb: Mark sync_all_pins() with static keyword Zou Wei
@ 2020-10-31 1:54 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2020-10-31 1:54 UTC (permalink / raw)
To: Zou Wei, alcooperx, gregkh, f.fainelli, bcm-kernel-feedback-list
Cc: linux-usb, linux-arm-kernel, linux-kernel
On 10/30/2020 6:48 PM, Zou Wei wrote:
> Fix the following sparse warning:
>
> ./brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?
>
> The sync_all_pins has only call site within brcmstb-usb-pinmap.c
> Mark it static as suggested.
>
> Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals")
Not sure if the Fixes: tag is entirely appropriate here, but sure, why not.
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-31 1:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-31 1:48 [PATCH -next v2] usb: Mark sync_all_pins() with static keyword Zou Wei
2020-10-31 1:54 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®