mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Xi Ruoyao" <xry111@xry111.site>,
	"Huacai Chen" <chenhuacai@kernel.org>,
	"Xuerui Wang" <kernel@xen0n.name>,
	"Arnd Bergmann" <arnd@arndb.de>
Cc: "Mingcong Bai" <jeffbai@aosc.io>,
	loongarch@lists.linux.dev,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] LoongArch: Don't define __ARCH_WANT_NEW_STAT for LA32
Date: Tue, 16 Dec 2025 15:03:11 +0800	[thread overview]
Message-ID: <72168037-f2e1-4107-bad6-ad2efdc6cbe7@app.fastmail.com> (raw)
In-Reply-To: <20251215033443.196159-2-xry111@xry111.site>



On Mon, 15 Dec 2025, at 11:34 AM, Xi Ruoyao wrote:
> While on LA64 we had added __ARCH_WANT_NEW_STAT back for technological
> aesthetics reason, on LA32 the newstat family suffers Y2038 issue and it
> should not be used at all, as the commit 82b355d161c9 ("y2038: Remove
> newstat family from default syscall set") has already pointed out.
>
> Fixes: 14338e631afd ("LoongArch: Adjust system call for 32BIT/64BIT")
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>

That makes sense, we certainly don't want any y2038 syscall.

Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Thanks!

> ---
>  arch/loongarch/include/asm/unistd.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/loongarch/include/asm/unistd.h 
> b/arch/loongarch/include/asm/unistd.h
> index e2c0f3d86c7b..4a7e4a6b6627 100644
> --- a/arch/loongarch/include/asm/unistd.h
> +++ b/arch/loongarch/include/asm/unistd.h
> @@ -8,7 +8,10 @@
> 
>  #include <uapi/asm/unistd.h>
> 
> +#if defined(__LP64__) && !defined(__SYSCALL_COMPAT)
>  #define __ARCH_WANT_NEW_STAT
> +#endif
> +
>  #define __ARCH_WANT_SYS_CLONE
> 
>  #define NR_syscalls (__NR_syscalls)
> -- 
> 2.52.0

-- 
- Jiaxun

  reply	other threads:[~2025-12-16  7:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15  3:34 Xi Ruoyao
2025-12-16  7:03 ` Jiaxun Yang [this message]
2025-12-16  7:21 ` Arnd Bergmann
2026-02-14 13:21 ` Ping: " Xi Ruoyao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72168037-f2e1-4107-bad6-ad2efdc6cbe7@app.fastmail.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=arnd@arndb.de \
    --cc=chenhuacai@kernel.org \
    --cc=jeffbai@aosc.io \
    --cc=kernel@xen0n.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®