From: "Arnd Bergmann" <arnd@arndb.de>
To: "Xi Ruoyao" <xry111@xry111.site>,
"Huacai Chen" <chenhuacai@kernel.org>,
"WANG Xuerui" <kernel@xen0n.name>
Cc: "Mingcong Bai" <jeffbai@aosc.io>,
loongarch@lists.linux.dev,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] LoongArch: Don't define __ARCH_WANT_NEW_STAT for LA32
Date: Tue, 16 Dec 2025 08:21:43 +0100 [thread overview]
Message-ID: <98d93330-844e-493d-8d7e-3455340b78b7@app.fastmail.com> (raw)
In-Reply-To: <20251215033443.196159-2-xry111@xry111.site>
On Mon, Dec 15, 2025, at 04:34, Xi Ruoyao wrote:
> While on LA64 we had added __ARCH_WANT_NEW_STAT back for technological
> aesthetics reason, on LA32 the newstat family suffers Y2038 issue and it
> should not be used at all, as the commit 82b355d161c9 ("y2038: Remove
> newstat family from default syscall set") has already pointed out.
>
> Fixes: 14338e631afd ("LoongArch: Adjust system call for 32BIT/64BIT")
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
The patch looks good to me.
Note that unlike the referenced 82b355d161c9 patch, this is no
longer needed for correctness, since modern kernels generate
the asm/unistd.h from the syscall.tbl based on
arch/loongarch/kernel/Makefile.syscalls, which leaves out the
references to newstat.
The patch is still useful of course, but only to slightly reduce
the size of the kernel image by eliminating dead code.
Arnd
next prev parent reply other threads:[~2025-12-16 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 3:34 Xi Ruoyao
2025-12-16 7:03 ` Jiaxun Yang
2025-12-16 7:21 ` Arnd Bergmann [this message]
2026-02-14 13:21 ` Ping: " Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98d93330-844e-493d-8d7e-3455340b78b7@app.fastmail.com \
--to=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=jeffbai@aosc.io \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®