From: Valdis.Kletnieks@vt.edu
To: Marcin Obara <marcin_obara@users.sourceforge.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jiri Slaby <jirislaby@gmail.com>,
tpm@selhorst.net, kjhall@us.ibm.com,
linux-kernel@vger.kernel.org, srajiv@linux.vnet.ibm.com,
debora@linux.vnet.ibm.com
Subject: Re: tpm-correct-tpm-timeouts-to-jiffies-conversion.patch -> 2.6.27
Date: Thu, 11 Sep 2008 23:10:08 -0400 [thread overview]
Message-ID: <7218.1221189008@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Thu, 11 Sep 2008 12:03:52 +0200." <ea8d860a0809110303g68d7cf2fs7affd9103abc9b24@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On Thu, 11 Sep 2008 12:03:52 +0200, Marcin Obara said:
> > Why? I wasn't aware that this fixed anything which anyone had observed
> > (pokes tongue out at the changelog).
> >
>
> This fixes i.e.: long hang while loading TPM driver, if TPM chip
> starts in "Idle" state instead of "Ready" state.
> Without this patch - 'modprobe' may hang for 30 seconds or more.
> Please, push this patch into 2.6.27.
I personally don't care whether this goes into .27 or waits till .28. However,
I *would* appreciate it if we make sure that whenever it goes go upstream, we
also send tpm-work-around-bug-in-broadcom-bcm0102-chipset.patch at the same
time.
I have to admit that it's not exactly confidence inspiring - if the Broadcom
chip gets timeout units wrong, what *other* issues lurk in its silicon? It's
bad enough when you find bugs in a RAID chipset or mouse hardware - it's even
worse when it's a security chip.. ;)
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
next prev parent reply other threads:[~2008-09-12 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 22:11 Jiri Slaby
2008-09-10 22:22 ` Andrew Morton
2008-09-11 10:03 ` Marcin Obara
2008-09-12 3:10 ` Valdis.Kletnieks [this message]
2008-09-12 15:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7218.1221189008@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=debora@linux.vnet.ibm.com \
--cc=jirislaby@gmail.com \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin_obara@users.sourceforge.net \
--cc=srajiv@linux.vnet.ibm.com \
--cc=tpm@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®