From: "Marcin Obara" <marcin_obara@users.sourceforge.net>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Jiri Slaby" <jirislaby@gmail.com>,
tpm@selhorst.net, kjhall@us.ibm.com,
linux-kernel@vger.kernel.org, srajiv@linux.vnet.ibm.com,
debora@linux.vnet.ibm.com
Subject: Re: tpm-correct-tpm-timeouts-to-jiffies-conversion.patch -> 2.6.27
Date: Thu, 11 Sep 2008 12:03:52 +0200 [thread overview]
Message-ID: <ea8d860a0809110303g68d7cf2fs7affd9103abc9b24@mail.gmail.com> (raw)
In-Reply-To: <20080910152258.762e3714.akpm@linux-foundation.org>
2008/9/11 Andrew Morton <akpm@linux-foundation.org>:
> On Thu, 11 Sep 2008 00:11:37 +0200
> Jiri Slaby <jirislaby@gmail.com> wrote:
>
>> Hi,
>>
>> is it possible to push
>> tpm-correct-tpm-timeouts-to-jiffies-conversion.patch
>> (the patch header follows) into 2.6.27, please?
>
> Sure.
>
>> From: Marcin Obara <marcin_obara@users.sourceforge.net>
>>
>> This patch fixes timeouts conversion to jiffies, by replacing
>> msecs_to_jiffies() calls with usecs_to_jiffies(). According to TCG TPM
>> Specification Version 1.2 Revision 103 (pages 166, 167) TPM timeouts and
>> durations are returned in microseconds (usec) not in miliseconds (msec).
>>
>> Signed-off-by: Marcin Obara <marcin_obara@users.sourceforge.net>
>> Cc: Marcel Selhorst <tpm@selhorst.net>
>> Cc: Kylene Jo Hall <kjhall@us.ibm.com>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> Why? I wasn't aware that this fixed anything which anyone had observed
> (pokes tongue out at the changelog).
>
This fixes i.e.: long hang while loading TPM driver, if TPM chip
starts in "Idle" state instead of "Ready" state.
Without this patch - 'modprobe' may hang for 30 seconds or more.
Please, push this patch into 2.6.27.
Marcin
next prev parent reply other threads:[~2008-09-11 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 22:11 Jiri Slaby
2008-09-10 22:22 ` Andrew Morton
2008-09-11 10:03 ` Marcin Obara [this message]
2008-09-12 3:10 ` Valdis.Kletnieks
2008-09-12 15:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea8d860a0809110303g68d7cf2fs7affd9103abc9b24@mail.gmail.com \
--to=marcin_obara@users.sourceforge.net \
--cc=akpm@linux-foundation.org \
--cc=debora@linux.vnet.ibm.com \
--cc=jirislaby@gmail.com \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srajiv@linux.vnet.ibm.com \
--cc=tpm@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®