* [PATCH] iommu/vt-d: Fix compile warning from intel-svm.h
@ 2020-02-10 9:36 Joerg Roedel
2020-02-11 0:24 ` Lu Baolu
0 siblings, 1 reply; 2+ messages in thread
From: Joerg Roedel @ 2020-02-10 9:36 UTC (permalink / raw)
To: iommu
Cc: David Woodhouse, Lu Baolu, Joerg Roedel, CQ Tang, Ashok Raj,
linux-kernel
From: Joerg Roedel <jroedel@suse.de>
The intel_svm_is_pasid_valid() needs to be marked inline, otherwise it
causes the compile warning below:
CC [M] drivers/dma/idxd/cdev.o
In file included from drivers/dma/idxd/cdev.c:9:0:
./include/linux/intel-svm.h:125:12: warning: ‘intel_svm_is_pasid_valid’ defined but not used [-Wunused-function]
static int intel_svm_is_pasid_valid(struct device *dev, int pasid)
^~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Borislav Petkov <bp@alien8.de>
Fixes: 15060aba71711 ('iommu/vt-d: Helper function to query if a pasid has any active users')
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
include/linux/intel-svm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/intel-svm.h b/include/linux/intel-svm.h
index 94f047a8a845..d7c403d0dd27 100644
--- a/include/linux/intel-svm.h
+++ b/include/linux/intel-svm.h
@@ -122,7 +122,7 @@ static inline int intel_svm_unbind_mm(struct device *dev, int pasid)
BUG();
}
-static int intel_svm_is_pasid_valid(struct device *dev, int pasid)
+static inline int intel_svm_is_pasid_valid(struct device *dev, int pasid)
{
return -EINVAL;
}
--
2.16.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] iommu/vt-d: Fix compile warning from intel-svm.h
2020-02-10 9:36 [PATCH] iommu/vt-d: Fix compile warning from intel-svm.h Joerg Roedel
@ 2020-02-11 0:24 ` Lu Baolu
0 siblings, 0 replies; 2+ messages in thread
From: Lu Baolu @ 2020-02-11 0:24 UTC (permalink / raw)
To: Joerg Roedel, iommu
Cc: David Woodhouse, Joerg Roedel, CQ Tang, Ashok Raj, linux-kernel
Hi Joerg,
On 2020/2/10 17:36, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> The intel_svm_is_pasid_valid() needs to be marked inline, otherwise it
> causes the compile warning below:
>
> CC [M] drivers/dma/idxd/cdev.o
> In file included from drivers/dma/idxd/cdev.c:9:0:
> ./include/linux/intel-svm.h:125:12: warning: ‘intel_svm_is_pasid_valid’ defined but not used [-Wunused-function]
> static int intel_svm_is_pasid_valid(struct device *dev, int pasid)
> ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Borislav Petkov <bp@alien8.de>
> Fixes: 15060aba71711 ('iommu/vt-d: Helper function to query if a pasid has any active users')
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
> ---
> include/linux/intel-svm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/intel-svm.h b/include/linux/intel-svm.h
> index 94f047a8a845..d7c403d0dd27 100644
> --- a/include/linux/intel-svm.h
> +++ b/include/linux/intel-svm.h
> @@ -122,7 +122,7 @@ static inline int intel_svm_unbind_mm(struct device *dev, int pasid)
> BUG();
> }
>
> -static int intel_svm_is_pasid_valid(struct device *dev, int pasid)
> +static inline int intel_svm_is_pasid_valid(struct device *dev, int pasid)
> {
> return -EINVAL;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-11 0:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 9:36 [PATCH] iommu/vt-d: Fix compile warning from intel-svm.h Joerg Roedel
2020-02-11 0:24 ` Lu Baolu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®