* [PATCH]fs: Fix to correct the mbcache entries counter
@ 2007-10-25 15:03 Ram Gupta
0 siblings, 0 replies; only message in thread
From: Ram Gupta @ 2007-10-25 15:03 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux mailing-list, torvalds
This patch fixes the c_entry_count counter of the mbcache. Currently
it increments the counter first & allocate the cache entry later. In
case of failure to allocate the entry due to insufficient memory this
counter is still left incremented. This patch fixes this anomaly.
Signed-off-by: Ram Gupta <ram.gupta5@gmail.com>
---------------
--- linux-2.6.23.1/fs/mbcache.c.orig 2007-10-25 09:19:28.000000000 -0500
+++ linux-2.6.23.1/fs/mbcache.c 2007-10-25 09:19:59.000000000 -0500
@@ -403,9 +403,9 @@ mb_cache_entry_alloc(struct mb_cache *ca
{
struct mb_cache_entry *ce;
- atomic_inc(&cache->c_entry_count);
ce = kmem_cache_alloc(cache->c_entry_cache, GFP_KERNEL);
if (ce) {
+ atomic_inc(&cache->c_entry_count);
INIT_LIST_HEAD(&ce->e_lru_list);
INIT_LIST_HEAD(&ce->e_block_list);
ce->e_cache = cache;
Thanks
Ram Gupta
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-10-25 15:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-25 15:03 [PATCH]fs: Fix to correct the mbcache entries counter Ram Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®