From: Robert Hancock <robert.hancock@calian.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "giometti@enneenne.com" <giometti@enneenne.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"rasm@fe.up.pt" <rasm@fe.up.pt>,
"jamesnuss@nanometrics.ca" <jamesnuss@nanometrics.ca>
Subject: Re: [PATCH] pps: clients: gpio: Propagate return value from pps_gpio_probe
Date: Wed, 2 Feb 2022 17:04:13 +0000 [thread overview]
Message-ID: <72a4b544d8ed7dc6ff809f21752dd56889185f65.camel@calian.com> (raw)
In-Reply-To: <5178d655-a9f0-0a0e-866c-b85b7eda69f3@enneenne.com>
On Sun, 2022-01-30 at 10:35 +0100, Rodolfo Giometti wrote:
> On 29/01/22 23:02, Robert Hancock wrote:
> > On Thu, 2022-01-13 at 09:17 +0100, Rodolfo Giometti wrote:
> > > On 12/01/22 22:07, Andy Shevchenko wrote:
> > > > On Wed, Jan 12, 2022 at 02:52:14PM -0600, Robert Hancock wrote:
> > > > > If the pps-gpio driver was probed prior to the GPIO device it uses,
> > > > > the
> > > > > devm_gpiod_get call returned an -EPROBE_DEFER error, but
> > > > > pps_gpio_probe
> > > > > replaced that error code with -EINVAL, causing the pps-gpio probe to
> > > > > fail and not be retried later. Propagate the error return value so
> > > > > that
> > > > > deferred probe works properly.
> > > >
> > > > FWIW,
> > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > Acked-by: Rodolfo Giometti <giometti@enneenne.com>
> >
> > It's not entirely clear to me what tree PPS patches are supposed to go
> > through.
> > Seems like some recent ones have gone through char-misc? Not sure if
> > someone
> > has this in their queue?
>
> LinuxPPS has no its own tree. All related patches usually are sent to me to
> be
> acked and to Greg Kroah-Hartman for inclusion.
>
> Ciao,
>
> Rodolfo
>
It looks like some MAINTAINERS links should maybe be updated for PPS - the
referenced page at http://wiki.enneenne.com/index.php/LinuxPPS_support seems to
be dead. There is http://linuxpps.org/doku.php which points to a new mailing
list location as well, but that seems to have very little activity.
Greg, can you pick this patch ( https://lkml.org/lkml/2022/1/12/879 ) up?
--
Robert Hancock
Senior Hardware Designer, Calian Advanced Technologies
www.calian.com
next prev parent reply other threads:[~2022-02-02 17:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 20:52 Robert Hancock
2022-01-12 21:07 ` Andy Shevchenko
2022-01-13 8:17 ` Rodolfo Giometti
2022-01-29 22:02 ` Robert Hancock
2022-01-30 9:35 ` Rodolfo Giometti
2022-02-02 17:04 ` Robert Hancock [this message]
2022-02-02 17:40 ` Rodolfo Giometti
2022-02-04 14:34 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72a4b544d8ed7dc6ff809f21752dd56889185f65.camel@calian.com \
--to=robert.hancock@calian.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=jamesnuss@nanometrics.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=rasm@fe.up.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®