mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: mingo@kernel.org, peterz@infradead.org, namhyung@kernel.org,
	jolsa@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf sched timehist: Improve error message when analyzing wrong file
Date: Tue, 29 Nov 2016 13:17:43 -0700	[thread overview]
Message-ID: <72c47909-8e9c-616c-1afe-5daa12f44473@gmail.com> (raw)
In-Reply-To: <20161129201404.GF23423@kernel.org>

On 11/29/16 1:14 PM, Arnaldo Carvalho de Melo wrote:
> It uses things like:
> 
>         if (kmem_page) {
>                 struct perf_evsel *evsel;
> 
>                 evsel = perf_evlist__find_tracepoint_by_name(session->evlist,
>                                                              "kmem:mm_page_alloc");
>                 if (evsel == NULL) {
>                         pr_err(errmsg, "page", "page");
>                         goto out_delete;
>                 }
> 

I thought something like existed but did not find it looking at kvm and sched commands. Will re-spin to be consistent with kmem.

      reply	other threads:[~2016-11-29 20:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 19:58 David Ahern
2016-11-29 20:14 ` Arnaldo Carvalho de Melo
2016-11-29 20:17   ` David Ahern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72c47909-8e9c-616c-1afe-5daa12f44473@gmail.com \
    --to=dsahern@gmail.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®