From: Joe Perches <joe@perches.com>
To: wangkailong@jari.cn, bp@alien8.de, mchehab@kernel.org,
tony.luck@intel.com, james.morse@arm.com, rric@kernel.org
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC: altera: Remove unnecessary print function dev_err()
Date: Sun, 06 Nov 2022 08:26:04 -0800 [thread overview]
Message-ID: <72d228fc27951a7ba9e607d9fc433b3c64a801e3.camel@perches.com> (raw)
In-Reply-To: <cf4581a.ba.1844d24fef3.Coremail.wangkailong@jari.cn>
On Sun, 2022-11-06 at 21:33 +0800, wangkailong@jari.cn wrote:
> Eliminate the follow coccicheck warning:
>
> ./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because
> platform_get_irq() already prints an error
> ./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because
> platform_get_irq() already prints an error
[]
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
[]
> @@ -2150,7 +2150,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>
> edac->sb_irq = platform_get_irq(pdev, 0);
> if (edac->sb_irq < 0) {
> - dev_err(&pdev->dev, "No SBERR IRQ resource\n");
> return edac->sb_irq;
> }
Should delete now unnecessary braces too
>
> @@ -2185,7 +2184,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
> #else
> edac->db_irq = platform_get_irq(pdev, 1);
> if (edac->db_irq < 0) {
> - dev_err(&pdev->dev, "No DBERR IRQ resource\n");
> return edac->db_irq;
> }
> irq_set_chained_handler_and_data(edac->db_irq,
prev parent reply other threads:[~2022-11-06 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 13:33 wangkailong
2022-11-06 16:26 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72d228fc27951a7ba9e607d9fc433b3c64a801e3.camel@perches.com \
--to=joe@perches.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=wangkailong@jari.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®