mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Baole Ni <baolex.ni@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0829/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 14:36:10 +0200	[thread overview]
Message-ID: <733db41f-a76e-6aa2-96a5-b1e31f126df6@suse.com> (raw)
In-Reply-To: <20160802115027.5246-1-baolex.ni@intel.com>

On 02/08/16 13:50, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>

This is the worst series of lkml spam I've ever received!

1. Make something like this a series in one thread, not 1285 single
   threads! Add a cover letter.
2. Don't write one patch per source file, one per subsystem is enough.
   Maybe even better: make a tree-wide patch using Coccinelle.
3. Use better subjects. I want to see the subsystem the patch is
   modifying.
4. Use _correct_ maintainers. WTF do I have to do with pcmcia?


Juergen

  reply	other threads:[~2016-08-02 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 11:50 Baole Ni
2016-08-02 12:36 ` Juergen Gross [this message]
2016-08-02 14:50 ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=733db41f-a76e-6aa2-96a5-b1e31f126df6@suse.com \
    --to=jgross@suse.com \
    --cc=baolex.ni@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®