* [PATCH] kernel: auditfilter: Remove unnecessary ‘0’ values from ret
@ 2023-12-28 2:56 Li zeming
2024-01-04 21:30 ` Paul Moore
2024-01-25 14:59 ` Paul Moore
0 siblings, 2 replies; 3+ messages in thread
From: Li zeming @ 2023-12-28 2:56 UTC (permalink / raw)
To: paul, eparis; +Cc: audit, linux-kernel, Li zeming
The ret variable is assigned when it does not need to be defined, as it
has already been assigned before use.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
kernel/auditfilter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index 8317a37dea0bb..be8c680121e46 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -788,7 +788,7 @@ static int audit_compare_rule(struct audit_krule *a, struct audit_krule *b)
static inline int audit_dupe_lsm_field(struct audit_field *df,
struct audit_field *sf)
{
- int ret = 0;
+ int ret;
char *lsm_str;
/* our own copy of lsm_str */
--
2.18.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kernel: auditfilter: Remove unnecessary ‘0’ values from ret
2023-12-28 2:56 [PATCH] kernel: auditfilter: Remove unnecessary ‘0’ values from ret Li zeming
@ 2024-01-04 21:30 ` Paul Moore
2024-01-25 14:59 ` Paul Moore
1 sibling, 0 replies; 3+ messages in thread
From: Paul Moore @ 2024-01-04 21:30 UTC (permalink / raw)
To: Li zeming; +Cc: eparis, audit, linux-kernel
On Wed, Dec 27, 2023 at 9:56 PM Li zeming <zeming@nfschina.com> wrote:
>
> The ret variable is assigned when it does not need to be defined, as it
> has already been assigned before use.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> kernel/auditfilter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the patch, as this is not a critical change it will be
processed after the upcoming merge window closes.
> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index 8317a37dea0bb..be8c680121e46 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -788,7 +788,7 @@ static int audit_compare_rule(struct audit_krule *a, struct audit_krule *b)
> static inline int audit_dupe_lsm_field(struct audit_field *df,
> struct audit_field *sf)
> {
> - int ret = 0;
> + int ret;
> char *lsm_str;
>
> /* our own copy of lsm_str */
> --
> 2.18.2
--
paul-moore.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kernel: auditfilter: Remove unnecessary ‘0’ values from ret
2023-12-28 2:56 [PATCH] kernel: auditfilter: Remove unnecessary ‘0’ values from ret Li zeming
2024-01-04 21:30 ` Paul Moore
@ 2024-01-25 14:59 ` Paul Moore
1 sibling, 0 replies; 3+ messages in thread
From: Paul Moore @ 2024-01-25 14:59 UTC (permalink / raw)
To: Li zeming, eparis; +Cc: audit, linux-kernel, Li zeming
On Dec 27, 2023 Li zeming <zeming@nfschina.com> wrote:
>
> The ret variable is assigned when it does not need to be defined, as it
> has already been assigned before use.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> kernel/auditfilter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Merged into audit/dev, thanks.
--
paul-moore.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-25 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-28 2:56 [PATCH] kernel: auditfilter: Remove unnecessary ‘0’ values from ret Li zeming
2024-01-04 21:30 ` Paul Moore
2024-01-25 14:59 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®