From: Randy Dunlap <rdunlap@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] arch/sh/: fix NUMA build errors
Date: Wed, 20 Nov 2019 08:13:18 -0800 [thread overview]
Message-ID: <736e66f5-85b6-6bbc-f902-9e72d8bc1a4a@infradead.org> (raw)
In-Reply-To: <CAMuHMdUyN5FE21C3Bu6S4wrwTxe0xB2ZpPAgryvx_6EX+YkhFw@mail.gmail.com>
On 11/20/19 12:30 AM, Geert Uytterhoeven wrote:
> Hi Randy,
>
> On Wed, Nov 20, 2019 at 5:28 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> On 11/18/19 11:38 PM, Geert Uytterhoeven wrote:
>>> On Tue, Nov 19, 2019 at 1:55 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>> From: Randy Dunlap <rdunlap@infradead.org>
>>>> Fix SUPERH builds that select SYS_SUPPORTS_NUMA but do not select
>>>> SYS_SUPPORTS_SMP and SMP.
>>>>
>>>> kernel/sched/topology.c is only built for CONFIG_SMP and then the NUMA
>>>> code + data inside topology.c is only built when CONFIG_NUMA is
>>>> set/enabled, so these arch/sh/ configs need to select SMP and
>>>> SYS_SUPPORTS_SMP to build the NUMA support.
>>>>
>>>> Fixes this build error in 3 different SUPERH configs:
>>>>
>>>> mm/page_alloc.o: In function `get_page_from_freelist':
>>>> page_alloc.c:(.text+0x2ca8): undefined reference to `node_reclaim_distance'
>>>>
>>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>>>> Cc: Rich Felker <dalias@libc.org>
>>>> Cc: linux-sh@vger.kernel.org
>>>> ---
>>>> or maybe these should be fixed in the defconfig files?
>>>>
>>>> or alternatively, does it make any sense to support NUMA without SMP?
>>>
>>> I think it does. From arch/sh/mm/Kconfig config NUMA help:
>>>
>>> Some SH systems have many various memories scattered around
>>> the address space, each with varying latencies. This enables
>>> support for these blocks by binding them to nodes and allowing
>>> memory policies to be used for prioritizing and controlling
>>> allocation behaviour.
>>
>> Note that this help text is under:
>> config NUMA
>> bool "Non-Uniform Memory Access (NUMA) Support"
>> depends on MMU && SYS_SUPPORTS_NUMA
>> select ARCH_WANT_NUMA_VARIABLE_LOCALITY
>>
>> but ARCH_WANT_NUMA_VARIABLE_LOCALITY seems to be unimplemented anywhere in
>> the kernel source tree. I.e., the Kconfig symbol exists in init/Kconfig,
>> but there is no code to support its use.
>
> It does control (prevent) another option:
>
> # For architectures that (ab)use NUMA to represent different memory regions
> # all cpu-local but of different latencies, such as SuperH.
> #
> config ARCH_WANT_NUMA_VARIABLE_LOCALITY
> bool
>
> config NUMA_BALANCING
> bool "Memory placement aware NUMA scheduler"
> depends on ARCH_SUPPORTS_NUMA_BALANCING
> depends on !ARCH_WANT_NUMA_VARIABLE_LOCALITY
> depends on SMP && NUMA && MIGRATION
> help
> This option adds support for automatic NUMA aware
> memory/task placement.
> The mechanism is quite primitive and is based on migrating memory when
> it has references to the node the task is running on.
>
> This system will be inactive on UMA systems.
>
> The symbol was set by arch/metag, too (which was removed).
I see. thanks.
--
~Randy
prev parent reply other threads:[~2019-11-20 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 0:55 Randy Dunlap
2019-11-19 7:38 ` Geert Uytterhoeven
2019-11-19 21:12 ` Randy Dunlap
2019-11-24 16:24 ` Randy Dunlap
2019-11-20 0:41 ` Randy Dunlap
2019-11-20 8:20 ` Geert Uytterhoeven
2019-11-20 4:27 ` Randy Dunlap
2019-11-20 8:30 ` Geert Uytterhoeven
2019-11-20 16:13 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=736e66f5-85b6-6bbc-f902-9e72d8bc1a4a@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®