From: Randy Dunlap <rdunlap@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] arch/sh/: fix NUMA build errors
Date: Tue, 19 Nov 2019 13:12:52 -0800 [thread overview]
Message-ID: <f45f983d-8ff1-a800-2706-d71413ae1824@infradead.org> (raw)
In-Reply-To: <CAMuHMdU0Vx1E9V+h8XYTyAJitPT42NdGvgzLAfG-=1BVZd-rbA@mail.gmail.com>
On 11/18/19 11:38 PM, Geert Uytterhoeven wrote:
> Hi Randy,
>
> On Tue, Nov 19, 2019 at 1:55 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>> Fix SUPERH builds that select SYS_SUPPORTS_NUMA but do not select
>> SYS_SUPPORTS_SMP and SMP.
>>
>> kernel/sched/topology.c is only built for CONFIG_SMP and then the NUMA
>> code + data inside topology.c is only built when CONFIG_NUMA is
>> set/enabled, so these arch/sh/ configs need to select SMP and
>> SYS_SUPPORTS_SMP to build the NUMA support.
>>
>> Fixes this build error in 3 different SUPERH configs:
>>
>> mm/page_alloc.o: In function `get_page_from_freelist':
>> page_alloc.c:(.text+0x2ca8): undefined reference to `node_reclaim_distance'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
>> Cc: Rich Felker <dalias@libc.org>
>> Cc: linux-sh@vger.kernel.org
>> ---
>> or maybe these should be fixed in the defconfig files?
>>
>> or alternatively, does it make any sense to support NUMA without SMP?
>
> I think it does. From arch/sh/mm/Kconfig config NUMA help:
>
> Some SH systems have many various memories scattered around
> the address space, each with varying latencies. This enables
> support for these blocks by binding them to nodes and allowing
> memory policies to be used for prioritizing and controlling
> allocation behaviour.
Yes, I saw that and suspected it also.
I was (and still am) hoping that a SuperH maintainer comments on
this and on how they are currently building kernels for these
failing configs. Maybe they have some patches that aren't in-tree yet?
> Probably the NUMA-core is too server/x86-centric, by assuming NUMA is
> used only on systems with multiple CPUs, each with their own RAM.
>
> AFAIK, none of the SoCs below are SMP:
>
>> --- lnx-54-rc8.orig/arch/sh/Kconfig
>> +++ lnx-54-rc8/arch/sh/Kconfig
>> @@ -508,6 +508,8 @@ config CPU_SUBTYPE_SH7722
>> select CPU_SHX2
>> select ARCH_SHMOBILE
>> select ARCH_SPARSEMEM_ENABLE
>> + select SYS_SUPPORTS_SMP
>> + select SMP
>> select SYS_SUPPORTS_NUMA
>> select SYS_SUPPORTS_SH_CMT
>> select PINCTRL
>> @@ -518,6 +520,8 @@ config CPU_SUBTYPE_SH7366
>> select CPU_SHX2
>> select ARCH_SHMOBILE
>> select ARCH_SPARSEMEM_ENABLE
>> + select SYS_SUPPORTS_SMP
>> + select SMP
>> select SYS_SUPPORTS_NUMA
>> select SYS_SUPPORTS_SH_CMT
>
> BTW, you didn't have the issue with CPU_SHX3 and CPU_SUBTYPE_SH7785?
I didn't see any issue there but I will check it again.
thanks.
--
~Randy
next prev parent reply other threads:[~2019-11-19 21:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 0:55 Randy Dunlap
2019-11-19 7:38 ` Geert Uytterhoeven
2019-11-19 21:12 ` Randy Dunlap [this message]
2019-11-24 16:24 ` Randy Dunlap
2019-11-20 0:41 ` Randy Dunlap
2019-11-20 8:20 ` Geert Uytterhoeven
2019-11-20 4:27 ` Randy Dunlap
2019-11-20 8:30 ` Geert Uytterhoeven
2019-11-20 16:13 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f45f983d-8ff1-a800-2706-d71413ae1824@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®