* [PATCH ath-next] wifi: ath12k: fix cleanup path after mhi init
@ 2025-04-03 10:04 Raj Kumar Bhagat
2025-04-09 7:23 ` Vasanthakumar Thiagarajan
2025-04-12 4:24 ` Jeff Johnson
0 siblings, 2 replies; 3+ messages in thread
From: Raj Kumar Bhagat @ 2025-04-03 10:04 UTC (permalink / raw)
To: Johannes Berg, Jeff Johnson, Kalle Valo, Kang Yang
Cc: Jeff Johnson, linux-wireless, ath12k, linux-kernel, Raj Kumar Bhagat
Currently, the 'err_pci_msi_free' label is misplaced, causing the cleanup
sequence to be incorrect. Fix this by moving the 'err_pci_msi_free' label
to the correct position after 'err_irq_affinity_cleanup'.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00209-QCAHKSWPL_SILICONZ-1
Fixes: a3012f206d07 ("wifi: ath12k: set IRQ affinity to CPU0 in case of one MSI vector")
Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
---
drivers/net/wireless/ath/ath12k/pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c
index 7f1bb150f326b317157f6721d990d61a27f38d6a..fcb9c40b227b7baaf49f6a590c495f47ca8d2f55 100644
--- a/drivers/net/wireless/ath/ath12k/pci.c
+++ b/drivers/net/wireless/ath/ath12k/pci.c
@@ -1706,12 +1706,12 @@ static int ath12k_pci_probe(struct pci_dev *pdev,
err_mhi_unregister:
ath12k_mhi_unregister(ab_pci);
-err_pci_msi_free:
- ath12k_pci_msi_free(ab_pci);
-
err_irq_affinity_cleanup:
ath12k_pci_set_irq_affinity_hint(ab_pci, NULL);
+err_pci_msi_free:
+ ath12k_pci_msi_free(ab_pci);
+
err_pci_free_region:
ath12k_pci_free_region(ab_pci);
---
base-commit: c0d45354abf5763f3de37d0c59fd863d193c7275
change-id: 20250403-ath12k-cleanup-2c56c001a1dc
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH ath-next] wifi: ath12k: fix cleanup path after mhi init
2025-04-03 10:04 [PATCH ath-next] wifi: ath12k: fix cleanup path after mhi init Raj Kumar Bhagat
@ 2025-04-09 7:23 ` Vasanthakumar Thiagarajan
2025-04-12 4:24 ` Jeff Johnson
1 sibling, 0 replies; 3+ messages in thread
From: Vasanthakumar Thiagarajan @ 2025-04-09 7:23 UTC (permalink / raw)
To: Raj Kumar Bhagat, Johannes Berg, Jeff Johnson, Kalle Valo, Kang Yang
Cc: Jeff Johnson, linux-wireless, ath12k, linux-kernel
On 4/3/2025 3:34 PM, Raj Kumar Bhagat wrote:
> Currently, the 'err_pci_msi_free' label is misplaced, causing the cleanup
> sequence to be incorrect. Fix this by moving the 'err_pci_msi_free' label
> to the correct position after 'err_irq_affinity_cleanup'.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00209-QCAHKSWPL_SILICONZ-1
>
> Fixes: a3012f206d07 ("wifi: ath12k: set IRQ affinity to CPU0 in case of one MSI vector")
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH ath-next] wifi: ath12k: fix cleanup path after mhi init
2025-04-03 10:04 [PATCH ath-next] wifi: ath12k: fix cleanup path after mhi init Raj Kumar Bhagat
2025-04-09 7:23 ` Vasanthakumar Thiagarajan
@ 2025-04-12 4:24 ` Jeff Johnson
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2025-04-12 4:24 UTC (permalink / raw)
To: Johannes Berg, Jeff Johnson, Kalle Valo, Kang Yang, Raj Kumar Bhagat
Cc: linux-wireless, ath12k, linux-kernel
On Thu, 03 Apr 2025 15:34:29 +0530, Raj Kumar Bhagat wrote:
> Currently, the 'err_pci_msi_free' label is misplaced, causing the cleanup
> sequence to be incorrect. Fix this by moving the 'err_pci_msi_free' label
> to the correct position after 'err_irq_affinity_cleanup'.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00209-QCAHKSWPL_SILICONZ-1
>
>
> [...]
Applied, thanks!
[1/1] wifi: ath12k: fix cleanup path after mhi init
commit: 6177c97fb6f05bf0473a2806e3bece7e77693209
Best regards,
--
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-12 4:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-03 10:04 [PATCH ath-next] wifi: ath12k: fix cleanup path after mhi init Raj Kumar Bhagat
2025-04-09 7:23 ` Vasanthakumar Thiagarajan
2025-04-12 4:24 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®