* [PATCH] usb: xhci: tegra: fix runtime PM error handling
@ 2018-06-17 11:12 Stefan Agner
2018-06-19 10:07 ` Jon Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Agner @ 2018-06-17 11:12 UTC (permalink / raw)
To: Jon Hunter, Greg Kroah-Hartman
Cc: Stefan Agner, Mathias Nyman, Thierry Reding, linux-usb,
linux-tegra, linux-kernel
The address-of operator will always evaluate to true. However,
power should be explicitly disabled if no power domain is used.
Remove the address-of operator.
Fixes: 58c38116c6cc ("usb: xhci: tegra: Add support for managing powergates")
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
drivers/usb/host/xhci-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
index a8c1d073cba0..33daac4136e8 100644
--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -1223,10 +1223,10 @@ static int tegra_xusb_probe(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev);
usb_put_hcd(tegra->hcd);
disable_xusbc:
- if (!&pdev->dev.pm_domain)
+ if (!pdev->dev.pm_domain)
tegra_powergate_power_off(TEGRA_POWERGATE_XUSBC);
disable_xusba:
- if (!&pdev->dev.pm_domain)
+ if (!pdev->dev.pm_domain)
tegra_powergate_power_off(TEGRA_POWERGATE_XUSBA);
put_padctl:
tegra_xusb_padctl_put(tegra->padctl);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] usb: xhci: tegra: fix runtime PM error handling
2018-06-17 11:12 [PATCH] usb: xhci: tegra: fix runtime PM error handling Stefan Agner
@ 2018-06-19 10:07 ` Jon Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Jon Hunter @ 2018-06-19 10:07 UTC (permalink / raw)
To: Stefan Agner, Greg Kroah-Hartman
Cc: Mathias Nyman, Thierry Reding, linux-usb, linux-tegra, linux-kernel
On 17/06/18 12:12, Stefan Agner wrote:
> The address-of operator will always evaluate to true. However,
> power should be explicitly disabled if no power domain is used.
>
> Remove the address-of operator.
>
> Fixes: 58c38116c6cc ("usb: xhci: tegra: Add support for managing powergates")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> drivers/usb/host/xhci-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
> index a8c1d073cba0..33daac4136e8 100644
> --- a/drivers/usb/host/xhci-tegra.c
> +++ b/drivers/usb/host/xhci-tegra.c
> @@ -1223,10 +1223,10 @@ static int tegra_xusb_probe(struct platform_device *pdev)
> pm_runtime_disable(&pdev->dev);
> usb_put_hcd(tegra->hcd);
> disable_xusbc:
> - if (!&pdev->dev.pm_domain)
> + if (!pdev->dev.pm_domain)
> tegra_powergate_power_off(TEGRA_POWERGATE_XUSBC);
> disable_xusba:
> - if (!&pdev->dev.pm_domain)
> + if (!pdev->dev.pm_domain)
> tegra_powergate_power_off(TEGRA_POWERGATE_XUSBA);
> put_padctl:
> tegra_xusb_padctl_put(tegra->padctl);
>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Thanks for fixing!
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-19 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-17 11:12 [PATCH] usb: xhci: tegra: fix runtime PM error handling Stefan Agner
2018-06-19 10:07 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®