From: Vincent Mailhol <mailhol@kernel.org>
To: Ard Biesheuvel <ardb+git@google.com>, linux-efi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
x86@kernel.org
Subject: Re: [PATCH v2 06/10] efi/libstub: Avoid efi_puts() for compile time constant strings
Date: Tue, 15 Sep 2026 19:01:09 +0200 [thread overview]
Message-ID: <7394c719-5e5c-4e38-8b83-c22868fb2425@kernel.org> (raw)
In-Reply-To: <20260909115530.1924665-18-ardb+git@google.com>
On 9/9/26 13:55, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> efi_puts() performs a UTF-8 to UTF-16 conversion on its input, as the
> EFI console's native character set is UTF-16.
>
> This is pointless for compile time constant strings, since we can
> simply define those as UTF-16 to begin with.
I would nuance this a bit. This is a trade-off between space and time.
ASCII text takes half of the space but needs a runtime conversion.
Note this is not an objection to the patch itself, but I think the
commit message could be slightly more nuanced.
> Note that efi_puts() also performs LF to CR-LF conversion, so this needs
> to be taken into account as well.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
(...)
Yours sincerely,
Vincent Mailhol
next prev parent reply other threads:[~2026-09-15 17:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 11:55 [PATCH v2 00/10] efi/libstub: Avoid UTF-16 conversion busywork Ard Biesheuvel
2026-09-09 11:55 ` [PATCH v2 01/10] x86/boot: Drop pointless re-implementation of panic() Ard Biesheuvel
2026-09-09 19:14 ` Borislav Petkov
2026-09-09 20:43 ` Ard Biesheuvel
2026-09-10 13:12 ` Kiryl Shutsemau
2026-09-11 7:32 ` Ard Biesheuvel
2026-09-12 6:10 ` Borislav Petkov
2026-09-12 8:41 ` Ard Biesheuvel
2026-09-12 17:54 ` Borislav Petkov
2026-09-13 16:35 ` Ard Biesheuvel
2026-09-13 18:11 ` Borislav Petkov
2026-09-09 11:55 ` [PATCH v2 02/10] lib/ucs2_string: Drop arbitrary input size limit and associated WARN() Ard Biesheuvel
2026-09-09 11:55 ` [PATCH v2 03/10] lib/ucs2_string: Suppress modinfo when __DISABLE_EXPORTS is set Ard Biesheuvel
2026-09-09 11:55 ` [PATCH v2 04/10] lib/ucs2_string: Split out ucs2_as_utf8_l() taking a separate limit Ard Biesheuvel
2026-09-09 11:55 ` [PATCH v2 05/10] efi/libstub: Use ucs2_string library for UTF-16 to UTF-8 conversion Ard Biesheuvel
2026-09-15 17:00 ` Vincent Mailhol
2026-09-09 11:55 ` [PATCH v2 06/10] efi/libstub: Avoid efi_puts() for compile time constant strings Ard Biesheuvel
2026-09-15 17:01 ` Vincent Mailhol [this message]
2026-09-09 11:55 ` [PATCH v2 07/10] efi/libstub: Output UTF-16 directly from vsnprintf() Ard Biesheuvel
2026-09-09 11:55 ` [PATCH v2 08/10] efi/libstub: Add support for printing human readable GUIDs Ard Biesheuvel
2026-09-09 11:55 ` [PATCH v2 09/10] efi/libstub: Add efi_snprintf() to construct wide strings Ard Biesheuvel
2026-09-15 17:02 ` Vincent Mailhol
2026-09-09 11:55 ` [PATCH v2 10/10] efi/libstub: add initial Boot Loader Interface support Ard Biesheuvel
2026-09-15 17:02 ` Vincent Mailhol
2026-09-15 18:28 ` [PATCH v2 00/10] efi/libstub: Avoid UTF-16 conversion busywork Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7394c719-5e5c-4e38-8b83-c22868fb2425@kernel.org \
--to=mailhol@kernel.org \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®