Re: [PATCH v4 6/6] hwmon: (peci/dimmtemp) Add support for Granite Rapids (GNR)

[Guenter Roeck <linux@roeck-us.net>]

On 11/2/26 01:57, Winiarska, Iwona wrote:
> On Fri, 2026-10-30 at 12:56 -0700, Guenter Roeck wrote:
>> On Mon, Oct 19, 2026 at 04:45:02AM -0700, Changhuang Liang wrote:
>>> Add support for Granite Rapids (GNR) platform in PECI DIMM temperature
>>> monitoring driver.
>>>
>>> The GNR platform has different DIMM topology from previous generations,
>>> with 12 channel ranks (CHAN_RANK_MAX_ON_GNR) and 2 DIMM indexes per
>>> channel. Define these new constants and update CHAN_RANK_MAX to use
>>> the GNR value since it represents the maximum across all supported
>>> platforms.
>>>
>>> Since the current peci core does not support domains, accessing GNR's
>>> DIMM_TEMP_MAX and DIMM_TEMP_CRIT via PECI commands will be rejected
>>> and return completion code 0x90 (invalid request). To handle this, the
>>> read_thresholds callback is not defined for GNR, and the visibility
>>> logic is updated to skip exposing the max and crit temperature
>>> attributes.
>>>
>>> The minimum PECI revision required for GNR is 0x42.
>>>
>>> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
>>> Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
>>
>> Acked-by: Guenter Roeck <linux@roeck-us.net>
> 
> Hi Guenter!
> 
> Could you please take the hwmon changes through your tree?
> 

Done.

Thanks,
Guenter