From: Guenter Roeck <linux@roeck-us.net>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Iwona Winiarska <iwona.winiarska@intel.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v4 6/6] hwmon: (peci/dimmtemp) Add support for Granite Rapids (GNR)
Date: Mon, 2 Nov 2026 07:04:36 -0800 [thread overview]
Message-ID: <8848aee0-9bdd-49c3-8b51-03eeab488bfa@roeck-us.net> (raw)
In-Reply-To: <20261019114502.55307-7-changhuang.liang@starfivetech.com>
On Mon, Oct 19, 2026 at 04:45:02AM -0700, Changhuang Liang wrote:
> Add support for Granite Rapids (GNR) platform in PECI DIMM temperature
> monitoring driver.
>
> The GNR platform has different DIMM topology from previous generations,
> with 12 channel ranks (CHAN_RANK_MAX_ON_GNR) and 2 DIMM indexes per
> channel. Define these new constants and update CHAN_RANK_MAX to use
> the GNR value since it represents the maximum across all supported
> platforms.
>
> Since the current peci core does not support domains, accessing GNR's
> DIMM_TEMP_MAX and DIMM_TEMP_CRIT via PECI commands will be rejected
> and return completion code 0x90 (invalid request). To handle this, the
> read_thresholds callback is not defined for GNR, and the visibility
> logic is updated to skip exposing the max and crit temperature
> attributes.
>
> The minimum PECI revision required for GNR is 0x42.
>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2026-11-02 15:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 11:44 [PATCH v4 0/6] Add StarFive JHB100 PECI support Changhuang Liang
2026-10-19 11:44 ` [PATCH v4 1/6] dt-bindings: peci: Add StarFive JHB100 PECI controller Changhuang Liang
2026-10-19 11:44 ` [PATCH v4 2/6] peci: controller: Add StarFive JHB100 PECI driver Changhuang Liang
2026-11-02 9:46 ` Winiarska, Iwona
2026-10-19 11:44 ` [PATCH v4 3/6] peci: Add support for PECI CC 0x83 retry condition Changhuang Liang
2026-10-19 11:45 ` [PATCH v4 4/6] peci: cpu: Add Intel Granite Rapids support Changhuang Liang
2026-10-19 11:45 ` [PATCH v4 5/6] hwmon: (peci/cputemp) Add support for Granite Rapids (GNR) Changhuang Liang
2026-10-30 19:56 ` Guenter Roeck
2026-11-02 15:03 ` Guenter Roeck
2026-10-19 11:45 ` [PATCH v4 6/6] hwmon: (peci/dimmtemp) " Changhuang Liang
2026-10-30 19:56 ` Guenter Roeck
2026-11-02 9:57 ` Winiarska, Iwona
2026-11-02 15:08 ` Guenter Roeck
2026-11-02 15:04 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8848aee0-9bdd-49c3-8b51-03eeab488bfa@roeck-us.net \
--to=linux@roeck-us.net \
--cc=changhuang.liang@starfivetech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iwona.winiarska@intel.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®