From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
David Howells <dhowells@redhat.com>
Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] afs: Remove erroneous fallthough annotation
Date: Wed, 26 Aug 2020 07:33:40 -0500 [thread overview]
Message-ID: <73c80979-da30-c7f5-eeac-9182076df023@embeddedor.com> (raw)
In-Reply-To: <20200826113214.GB393664@mwanda>
On 8/26/20 06:32, Dan Carpenter wrote:
> The fall through annotation comes after a return statement so it's not
> reachable.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> fs/afs/flock.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/afs/flock.c b/fs/afs/flock.c
> index eff82a6839e4..cb3054c7843e 100644
> --- a/fs/afs/flock.c
> +++ b/fs/afs/flock.c
> @@ -376,7 +376,6 @@ void afs_lock_work(struct work_struct *work)
> spin_unlock(&vnode->lock);
> return;
>
> - fallthrough;
> default:
> /* Looks like a lock request was withdrawn. */
> spin_unlock(&vnode->lock);
>
prev parent reply other threads:[~2020-08-26 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 11:32 Dan Carpenter
2020-08-26 12:33 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73c80979-da30-c7f5-eeac-9182076df023@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=dan.carpenter@oracle.com \
--cc=dhowells@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®