* [PATCH] afs: Remove erroneous fallthough annotation
@ 2020-08-26 11:32 Dan Carpenter
2020-08-26 12:33 ` Gustavo A. R. Silva
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-08-26 11:32 UTC (permalink / raw)
To: David Howells; +Cc: linux-afs, linux-kernel, kernel-janitors
The fall through annotation comes after a return statement so it's not
reachable.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
fs/afs/flock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/afs/flock.c b/fs/afs/flock.c
index eff82a6839e4..cb3054c7843e 100644
--- a/fs/afs/flock.c
+++ b/fs/afs/flock.c
@@ -376,7 +376,6 @@ void afs_lock_work(struct work_struct *work)
spin_unlock(&vnode->lock);
return;
- fallthrough;
default:
/* Looks like a lock request was withdrawn. */
spin_unlock(&vnode->lock);
--
2.28.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] afs: Remove erroneous fallthough annotation
2020-08-26 11:32 [PATCH] afs: Remove erroneous fallthough annotation Dan Carpenter
@ 2020-08-26 12:33 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2020-08-26 12:33 UTC (permalink / raw)
To: Dan Carpenter, David Howells; +Cc: linux-afs, linux-kernel, kernel-janitors
On 8/26/20 06:32, Dan Carpenter wrote:
> The fall through annotation comes after a return statement so it's not
> reachable.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
> ---
> fs/afs/flock.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/afs/flock.c b/fs/afs/flock.c
> index eff82a6839e4..cb3054c7843e 100644
> --- a/fs/afs/flock.c
> +++ b/fs/afs/flock.c
> @@ -376,7 +376,6 @@ void afs_lock_work(struct work_struct *work)
> spin_unlock(&vnode->lock);
> return;
>
> - fallthrough;
> default:
> /* Looks like a lock request was withdrawn. */
> spin_unlock(&vnode->lock);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-26 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 11:32 [PATCH] afs: Remove erroneous fallthough annotation Dan Carpenter
2020-08-26 12:33 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®