From: Waiman Long <llong@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>
Subject: Re: [PATCH] locking/rtmutex: Use struct keyword in kernel-doc comment
Date: Sun, 12 Jan 2025 22:28:01 -0500 [thread overview]
Message-ID: <73fc5150-ecfe-4dbc-8188-acb818c1cfa2@redhat.com> (raw)
In-Reply-To: <20250111063040.910763-1-rdunlap@infradead.org>
On 1/11/25 1:30 AM, Randy Dunlap wrote:
> Add the "struct" keyword to prevent a kernel-doc warning:
>
> rtmutex_common.h:67: warning: cannot understand function prototype: 'struct rt_wake_q_head '
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Waiman Long <longman@redhat.com>
> Cc: Boqun Feng <boqun.feng@gmail.com>
> ---
> kernel/locking/rtmutex_common.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20250108.orig/kernel/locking/rtmutex_common.h
> +++ linux-next-20250108/kernel/locking/rtmutex_common.h
> @@ -59,8 +59,8 @@ struct rt_mutex_waiter {
> };
>
> /**
> - * rt_wake_q_head - Wrapper around regular wake_q_head to support
> - * "sleeping" spinlocks on RT
> + * struct rt_wake_q_head - Wrapper around regular wake_q_head to support
> + * "sleeping" spinlocks on RT
> * @head: The regular wake_q_head for sleeping lock variants
> * @rtlock_task: Task pointer for RT lock (spin/rwlock) wakeups
> */
>
Acked-by: Waiman Long <longman@redhat.com>
next prev parent reply other threads:[~2025-01-13 3:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 6:30 Randy Dunlap
2025-01-13 3:28 ` Waiman Long [this message]
2025-03-03 18:51 ` [tip: locking/core] " tip-bot2 for Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73fc5150-ecfe-4dbc-8188-acb818c1cfa2@redhat.com \
--to=llong@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®