From: Markus Elfring <Markus.Elfring@web.de>
To: Chen Changcheng <chenchangcheng@kylinos.cn>,
linux-media@vger.kernel.org,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: dm1105: fix rc_dev leak on probe error paths
Date: Mon, 26 Oct 2026 16:45:58 +0100 [thread overview]
Message-ID: <74064ad6-8a0c-45c6-bdfb-0b4eb21d0f3e@web.de> (raw)
In-Reply-To: <20261026082718.89558-1-chenchangcheng@kylinos.cn>
> dm1105_ir_init() registers an rc_dev that must be cleaned up by
> dm1105_ir_exit(). However, in dm1105_probe() the return value of
> dm1105_ir_init() is ignored, and neither the workqueue nor the
…
I propose to refine the change description another bit.
Wording suggestion:
The return value of a dm1105_ir_init() call was ignored within dm1105_probe().
The error detection and exception handling was incomplete.
Thus add a needed condition check.
Adjust a subsequent jump target for the completion of the desired error handling.
…
> ---
> drivers/media/pci/dm1105/dm1105.c | 8 ++++++--
…
Some contributors would appreciate patch version descriptions.
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3#n310
Regards,
Markus
next prev parent reply other threads:[~2026-10-26 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 1:38 Chen Changcheng
2026-10-23 18:30 ` Markus Elfring
2026-10-26 8:27 ` Chen Changcheng
2026-10-26 15:45 ` Markus Elfring [this message]
2026-10-27 1:10 ` [PATCH v3] " Chen Changcheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74064ad6-8a0c-45c6-bdfb-0b4eb21d0f3e@web.de \
--to=markus.elfring@web.de \
--cc=chenchangcheng@kylinos.cn \
--cc=hverkuil+cisco@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®