From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Jessica Zhang" <quic_jesszhan@quicinc.com>,
"Rob Clark" <robdclark@gmail.com>, "Sean Paul" <sean@poorly.run>
Cc: <intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>,
<freedreno@lists.freedesktop.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 2/2] drm/msm: add another DRM_DISPLAY_DSC_HELPER selection
Date: Sun, 13 Oct 2024 20:11:38 -0700 [thread overview]
Message-ID: <741111f4-a5de-4c87-9278-c91fc92480ca@quicinc.com> (raw)
In-Reply-To: <20240905-fix-dsc-helpers-v1-2-3ae4b5900f89@linaro.org>
On 9/4/2024 8:08 PM, Dmitry Baryshkov wrote:
> In the drm/msm driver both DSI and DPU subdrivers use drm_dsc_*
> functions, but only DSI selects DRM_DISPLAY_DSC_HELPER symbol. Add
> missing select to the DPU subdriver too.
>
> Fixes: ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409040129.rqhtRTeC-lkp@intel.com/
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Change LGTM, hence
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
But, ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers") is
not yet merged, so I will not be able to pick this up for this cycle?
> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index 94d3ed4f7761..c8dda0ebd043 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -92,6 +92,7 @@ config DRM_MSM_DPU
> bool "Enable DPU support in MSM DRM driver"
> depends on DRM_MSM
> select DRM_MSM_MDSS
> + select DRM_DISPLAY_DSC_HELPER
> default y
> help
> Compile in support for the Display Processing Unit in
>
next prev parent reply other threads:[~2024-10-14 3:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 3:08 [PATCH 0/2] drm: add two missing DRM_DISPLAY_DSC_HELPER selects Dmitry Baryshkov
2024-09-05 3:08 ` [PATCH 1/2] drm/xe: select DRM_DISPLAY_DSC_HELPER Dmitry Baryshkov
2024-09-05 3:08 ` [PATCH 2/2] drm/msm: add another DRM_DISPLAY_DSC_HELPER selection Dmitry Baryshkov
2024-10-14 3:11 ` Abhinav Kumar [this message]
2024-10-14 3:20 ` Abhinav Kumar
2024-09-05 7:47 ` [PATCH 0/2] drm: add two missing DRM_DISPLAY_DSC_HELPER selects Maxime Ripard
2024-09-05 12:40 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=741111f4-a5de-4c87-9278-c91fc92480ca@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®