[PATCH 0/2] drm: add two missing DRM_DISPLAY_DSC_HELPER selects

[PATCH 0/2] drm: add two missing DRM_DISPLAY_DSC_HELPER selects

[Dmitry Baryshkov]

Add two selects for DRM_DISPLAY_DSC_HELPER which got missed in the
original commit ca097d4d94d8 ("drm/display: split DSC helpers from DP
helpers") and were later reported by LKP.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Dmitry Baryshkov (2):
      drm/xe: select DRM_DISPLAY_DSC_HELPER
      drm/msm: add another DRM_DISPLAY_DSC_HELPER selection

 drivers/gpu/drm/msm/Kconfig | 1 +
 drivers/gpu/drm/xe/Kconfig  | 1 +
 2 files changed, 2 insertions(+)
---
base-commit: fdadd93817f124fd0ea6ef251d4a1068b7feceba
change-id: 20240905-fix-dsc-helpers-3b8460fcb9af

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

[PATCH 1/2] drm/xe: select DRM_DISPLAY_DSC_HELPER

[Dmitry Baryshkov]

The Xe driver shares display code with the i915 driver, pulling in the
dependency on the DSC helpers this way. However when working on
separating DRM_DISPLAY_DSC_HELPER this was left unnoticed. Add missing
dependency.

Fixes: ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202409032226.x6f4SWQl-lkp@intel.com/
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/gpu/drm/xe/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
index 7bbe46a98ff1..ebd0879e04d4 100644
--- a/drivers/gpu/drm/xe/Kconfig
+++ b/drivers/gpu/drm/xe/Kconfig
@@ -14,6 +14,7 @@ config DRM_XE
 	select DRM_PANEL
 	select DRM_SUBALLOC_HELPER
 	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_DSC_HELPER
 	select DRM_DISPLAY_HDCP_HELPER
 	select DRM_DISPLAY_HDMI_HELPER
 	select DRM_DISPLAY_HELPER

-- 
2.39.2

[PATCH 2/2] drm/msm: add another DRM_DISPLAY_DSC_HELPER selection

[Dmitry Baryshkov]

In the drm/msm driver both DSI and DPU subdrivers use drm_dsc_*
functions, but only DSI selects DRM_DISPLAY_DSC_HELPER symbol. Add
missing select to the DPU subdriver too.

Fixes: ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202409040129.rqhtRTeC-lkp@intel.com/
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/gpu/drm/msm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
index 94d3ed4f7761..c8dda0ebd043 100644
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -92,6 +92,7 @@ config DRM_MSM_DPU
 	bool "Enable DPU support in MSM DRM driver"
 	depends on DRM_MSM
 	select DRM_MSM_MDSS
+	select DRM_DISPLAY_DSC_HELPER
 	default y
 	help
 	  Compile in support for the Display Processing Unit in

-- 
2.39.2

Re: [PATCH 2/2] drm/msm: add another DRM_DISPLAY_DSC_HELPER selection

[Abhinav Kumar]

On 9/4/2024 8:08 PM, Dmitry Baryshkov wrote:
> In the drm/msm driver both DSI and DPU subdrivers use drm_dsc_*
> functions, but only DSI selects DRM_DISPLAY_DSC_HELPER symbol. Add
> missing select to the DPU subdriver too.
> 
> Fixes: ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409040129.rqhtRTeC-lkp@intel.com/
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   drivers/gpu/drm/msm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 

Change LGTM, hence

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>

But, ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers") is 
not yet merged, so I will not be able to pick this up for this cycle?

> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index 94d3ed4f7761..c8dda0ebd043 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -92,6 +92,7 @@ config DRM_MSM_DPU
>   	bool "Enable DPU support in MSM DRM driver"
>   	depends on DRM_MSM
>   	select DRM_MSM_MDSS
> +	select DRM_DISPLAY_DSC_HELPER
>   	default y
>   	help
>   	  Compile in support for the Display Processing Unit in
> 

Re: [PATCH 2/2] drm/msm: add another DRM_DISPLAY_DSC_HELPER selection

[Abhinav Kumar]

On 10/13/2024 8:11 PM, Abhinav Kumar wrote:
> 
> 
> On 9/4/2024 8:08 PM, Dmitry Baryshkov wrote:
>> In the drm/msm driver both DSI and DPU subdrivers use drm_dsc_*
>> functions, but only DSI selects DRM_DISPLAY_DSC_HELPER symbol. Add
>> missing select to the DPU subdriver too.
>>
>> Fixes: ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: 
>> https://lore.kernel.org/oe-kbuild-all/202409040129.rqhtRTeC-lkp@intel.com/
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>   drivers/gpu/drm/msm/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
> 
> Change LGTM, hence
> 
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> 
> But, ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers") is 
> not yet merged, so I will not be able to pick this up for this cycle?
>

Please ignore, I just noticed this series was applied through drm-misc.

>> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
>> index 94d3ed4f7761..c8dda0ebd043 100644
>> --- a/drivers/gpu/drm/msm/Kconfig
>> +++ b/drivers/gpu/drm/msm/Kconfig
>> @@ -92,6 +92,7 @@ config DRM_MSM_DPU
>>       bool "Enable DPU support in MSM DRM driver"
>>       depends on DRM_MSM
>>       select DRM_MSM_MDSS
>> +    select DRM_DISPLAY_DSC_HELPER
>>       default y
>>       help
>>         Compile in support for the Display Processing Unit in
>>

Re: [PATCH 0/2] drm: add two missing DRM_DISPLAY_DSC_HELPER selects

[Maxime Ripard]

On Thu, 05 Sep 2024 06:08:20 +0300, Dmitry Baryshkov wrote:
> Add two selects for DRM_DISPLAY_DSC_HELPER which got missed in the
> original commit ca097d4d94d8 ("drm/display: split DSC helpers from DP
> helpers") and were later reported by LKP.
> 
> 

Applied to misc/kernel.git (drm-misc-next).

Thanks!
Maxime

Re: [PATCH 0/2] drm: add two missing DRM_DISPLAY_DSC_HELPER selects

[Dmitry Baryshkov]

On Thu, 5 Sept 2024 at 10:48, Maxime Ripard <mripard@kernel.org> wrote:
>
> On Thu, 05 Sep 2024 06:08:20 +0300, Dmitry Baryshkov wrote:
> > Add two selects for DRM_DISPLAY_DSC_HELPER which got missed in the
> > original commit ca097d4d94d8 ("drm/display: split DSC helpers from DP
> > helpers") and were later reported by LKP.
> >
> >
>
> Applied to misc/kernel.git (drm-misc-next).

Thanks!


-- 
With best wishes
Dmitry