From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Mahadevan <quic_mahap@quicinc.com>,
<linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<freedreno@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] dt-bindings: display: msm: dp-controller: document clock parents better
Date: Tue, 22 Apr 2025 19:40:17 -0700 [thread overview]
Message-ID: <743721c3-9015-4d3b-902d-cfa6ea4e94af@quicinc.com> (raw)
In-Reply-To: <CAA8EJpotUkPWU4VTmtaH=XkhwPZVXfdU8ZyHqROYpZRWDdYPSQ@mail.gmail.com>
Hi Krzysztof and Dmitry
Sorry for the late response.
On 12/5/2024 3:32 AM, Dmitry Baryshkov wrote:
> On Thu, 5 Dec 2024 at 09:33, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 04/12/2024 11:09, Dmitry Baryshkov wrote:
>>> On Wed, Dec 04, 2024 at 09:02:18AM +0100, Krzysztof Kozlowski wrote:
>>>> On Tue, Dec 03, 2024 at 03:41:48PM +0200, Dmitry Baryshkov wrote:
>>>>> On Tue, Dec 03, 2024 at 09:01:31AM +0100, Krzysztof Kozlowski wrote:
>>>>>> On 03/12/2024 04:31, Abhinav Kumar wrote:
>>>>>>> Document the assigned-clock-parents better for the DP controller node
>>>>>>> to indicate its functionality better.
>>>>>>
>>>>>>
>>>>>> You change the clocks entirely, not "document". I would say that's an
>>>>>> ABI break if it really is a Linux requirement. You could avoid any
>>>>>> problems by just dropping the property from binding.
>>>>>
>>>>> But if you take a look at the existing usage, the proposed change
>>>>> matches the behaviour. So, I'd say, it's really a change that makes
>>>>> documentation follow the actual hardware.
>>>>
Yes, I was trying to document it better and that way adding/extending
more streams becomes easier for the next patches in the series.
>>>> First, this should be in the commit msg, instead of "document better to
>>>> indicate functionality better".
>>>>
>>>> Second, what is the point of documenting it in the first place if you
>>>> can change it and changing has no impact? So maybe just drop?
>>>
>>> So, do you suggest setting both of the property descriptions to true? Or
>>> dropping them completely and using unevaluatedProperties instead of
>>> additionalProperties?
>>>
>>
>> Dropping them entirely, without any changes of additionalProperties.
>> Unless this property was added due to limitation of dtschema?
>
> I don't remember at this point. I think it's worth trying to drop them.
>
I tried dropping assigned-clock-parents altogether and it seems fine, No
schema/errors of warnings if I also fixup the examples in
qcom,sc7180-mdss.yaml and qcom,sa8775p-mdss.yaml to drop the usage.
So I can go ahead with dropping it.
Thanks
Abhinav
next prev parent reply other threads:[~2025-04-23 2:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 3:31 [PATCH 0/4] dt-bindings: msm/dp: add support for pixel clock to driver another stream Abhinav Kumar
2024-12-03 3:31 ` [PATCH 1/4] dt-bindings: display: msm: dp-controller: document pixel clock stream Abhinav Kumar
2024-12-03 8:01 ` Krzysztof Kozlowski
2025-04-23 2:23 ` Abhinav Kumar
2024-12-03 3:31 ` [PATCH 2/4] dt-bindings: display: msm: dp-controller: document clock parents better Abhinav Kumar
2024-12-03 8:01 ` Krzysztof Kozlowski
2024-12-03 13:41 ` Dmitry Baryshkov
2024-12-04 8:02 ` Krzysztof Kozlowski
2024-12-04 10:09 ` Dmitry Baryshkov
2024-12-05 7:33 ` Krzysztof Kozlowski
2024-12-05 11:32 ` Dmitry Baryshkov
2025-04-23 2:40 ` Abhinav Kumar [this message]
2024-12-03 3:31 ` [PATCH 3/4] dt-bindings: display/msm: add stream 1 pixel clock binding Abhinav Kumar
2024-12-03 8:04 ` Krzysztof Kozlowski
2025-04-23 2:46 ` Abhinav Kumar
2025-05-08 6:18 ` Krzysztof Kozlowski
2025-05-22 0:49 ` Abhinav Kumar
2024-12-03 13:43 ` Dmitry Baryshkov
2025-04-23 2:46 ` Abhinav Kumar
2025-04-23 14:23 ` Dmitry Baryshkov
2025-05-22 0:48 ` Abhinav Kumar
2024-12-03 3:31 ` [PATCH 4/4] dt-bindings: display: msm: dp: update maintainer entry Abhinav Kumar
2024-12-10 9:24 ` Krzysztof Kozlowski
2024-12-10 22:21 ` [PATCH 0/4] dt-bindings: msm/dp: add support for pixel clock to driver another stream Marijn Suijten
2024-12-24 20:41 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=743721c3-9015-4d3b-902d-cfa6ea4e94af@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_khsieh@quicinc.com \
--cc=quic_mahap@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®