* [PATCH] tracing: add missing spaces after ';' [not found] <20230719064321.19047-1-xujianghui@cdjrlc.com> @ 2023-07-20 2:30 ` wuyonggang001 2023-07-20 17:45 ` Steven Rostedt 0 siblings, 1 reply; 3+ messages in thread From: wuyonggang001 @ 2023-07-20 2:30 UTC (permalink / raw) To: rostedt, mhiramat; +Cc: linux-kernel, linux-trace-kernel Remove spaces to clear checkpatch errors. ERROR: space required after that ';' (ctx:VxV) Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com> --- include/trace/stages/stage4_event_fields.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/stages/stage4_event_fields.h b/include/trace/stages/stage4_event_fields.h index b6f679ae21aa..9627e081a990 100644 --- a/include/trace/stages/stage4_event_fields.h +++ b/include/trace/stages/stage4_event_fields.h @@ -2,7 +2,7 @@ /* Stage 4 definitions for creating trace events */ -#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b;}))) +#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b; }))) #undef __field_ext #define __field_ext(_type, _item, _filter_type) { \ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tracing: add missing spaces after ';' 2023-07-20 2:30 ` [PATCH] tracing: add missing spaces after ';' wuyonggang001 @ 2023-07-20 17:45 ` Steven Rostedt 0 siblings, 0 replies; 3+ messages in thread From: Steven Rostedt @ 2023-07-20 17:45 UTC (permalink / raw) To: wuyonggang001; +Cc: mhiramat, linux-kernel, linux-trace-kernel On Thu, 20 Jul 2023 10:30:36 +0800 wuyonggang001@208suo.com wrote: > Remove spaces to clear checkpatch errors. > > ERROR: space required after that ';' (ctx:VxV) PLEASE DO NOT RUN CHECKPATCH ON CURRENT CODE!!!! As the name suggests, checkpatch is for patches and not for existing code. It is used as a guideline tool to make clean patches. But checkpatch is *NOT* the rule of the kernel. There's lots of issues that checkpatch reports that can be ignored. That is decided when the patch is submitted, and SHOULD NOT be revisited once it has been accepted. Not to mention this particular error is silly. NACK!!! -- Steve > > Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com> > --- > include/trace/stages/stage4_event_fields.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/trace/stages/stage4_event_fields.h > b/include/trace/stages/stage4_event_fields.h > index b6f679ae21aa..9627e081a990 100644 > --- a/include/trace/stages/stage4_event_fields.h > +++ b/include/trace/stages/stage4_event_fields.h > @@ -2,7 +2,7 @@ > > /* Stage 4 definitions for creating trace events */ > > -#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b;}))) > +#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b; }))) > > #undef __field_ext > #define __field_ext(_type, _item, _filter_type) { \ ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20230719041722.18919-1-xujianghui@cdjrlc.com>]
* [PATCH] tracing: add missing spaces after ';' [not found] <20230719041722.18919-1-xujianghui@cdjrlc.com> @ 2023-07-19 7:10 ` sunran001 0 siblings, 0 replies; 3+ messages in thread From: sunran001 @ 2023-07-19 7:10 UTC (permalink / raw) To: rostedt, mhiramat; +Cc: linux-kernel Remove spaces to clear checkpatch errors. ERROR: space required after that ';' (ctx:VxV) Signed-off-by: Ran Sun <sunran001@208suo.com> --- include/trace/stages/stage4_event_fields.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/stages/stage4_event_fields.h b/include/trace/stages/stage4_event_fields.h index b6f679ae21aa..9627e081a990 100644 --- a/include/trace/stages/stage4_event_fields.h +++ b/include/trace/stages/stage4_event_fields.h @@ -2,7 +2,7 @@ /* Stage 4 definitions for creating trace events */ -#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b;}))) +#define ALIGN_STRUCTFIELD(type) ((int)(__alignof__(struct {type b; }))) #undef __field_ext #define __field_ext(_type, _item, _filter_type) { \ ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-20 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230719064321.19047-1-xujianghui@cdjrlc.com>
2023-07-20 2:30 ` [PATCH] tracing: add missing spaces after ';' wuyonggang001
2023-07-20 17:45 ` Steven Rostedt
[not found] <20230719041722.18919-1-xujianghui@cdjrlc.com>
2023-07-19 7:10 ` sunran001
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome