mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Sam Day <me@samcday.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: add panel rails to simplefb
Date: Tue, 30 Jun 2026 16:47:47 +0200	[thread overview]
Message-ID: <746aa10f-65e4-46d0-8db4-bc6314343f9d@oss.qualcomm.com> (raw)
In-Reply-To: <6MmdbjsuzuidbfnSBPTziatRh-MvvYkxzODIjsq8bXLfdTs-DzdUHnwdKwSaxueLHWI3nKUEzU-rzwTdlAGbegYrjKf_IeLk-bynAUkxVOA=@samcday.com>

On 6/30/26 12:51 AM, Sam Day wrote:
> Hi Konrad,
> 
> On Tuesday, 30 June 2026 at 8:39 AM, Sam Day <me@samcday.com> wrote:
> 
>> Hey Konrad,
>>
>> On Tuesday, 30 June 2026 at 12:24 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
>>
>>> On 6/20/26 1:15 AM, Sam Day wrote:
>>>> Hello Konrad,
>>>>
>>>> On Saturday, 20 June 2026 at 1:11 AM, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
>>>>
>>>>> On 6/16/26 7:27 AM, Sam Day via B4 Relay wrote:
>>>>>> From: Sam Day <me@samcday.com>
>>>>>>
>>>>>> These regulators are marked regulator-boot-on, but that doesn't
>>>>>> guarantee they'll stay alive as long as the simplefb does. Adding the
>>>>>> explicit supplies ensures that booting with MDSS disabled doesn't
>>>>>> switch the panel off 30 seconds after boot.
>>>>>
>>>>> Why would you boot without MDSS if you want the panel to function?
>>>>
>>>> For my particular use-case [1] I'm trying to avoid taking over the display
>>>> hardware entirely, and use simplefb until kexecing into the real kernel. In
>>>> this case the user might halt in a pre-boot menu UI for a while.
>>>>
>>>> I can also imagine this being similarly useful for "recovery kernel" use-cases
>>>> where again, it may not be desirable to assume control of MDSS/MDP/DSI blocks.
>>>>
>>>> [1]: https://github.com/samcday/pocketboot
>>>
>>> Can you handle this by adding a panel = <&display_panel> property
>>> under simplefb, pointing to the display panel defined in the same
>>> file?
>>
>> No, that won't work because display_panel is a child of mdss_dsi0, which is
>> a child of mdss. So if those nodes are disabled (which is what I'm trying to
>> achieve), fw_devlink will defer probing simplefb.
> 
> I apologize for spamming you with false assertions! I just realized that
> fw_devlink won't step in and enforce such probe deferral unless the property
> explicitly ends with -supply.
> 
> However, I tried your suggestion and confirm that the LCD_VCI_3V + VDDI_POC
> regulators are still turned off by regulator_init_complete_work(). Since I've
> already embarrassed myself once today I'm not going to attempt to speculate as
> to why :)

That's the way we all learn!

Looks like the answer is 'because nothing grabs these regulators'..
At a glance, grabbing a regulator reference is strictly tied to a
struct device (and its fwnode), so it's probably not so easy to make it..

Konrad

      reply	other threads:[~2026-06-30 14:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16  5:27 Sam Day via B4 Relay
2026-06-19 15:10 ` Konrad Dybcio
2026-06-19 23:15   ` Sam Day
2026-06-29 14:24     ` Konrad Dybcio
2026-06-29 22:39       ` Sam Day
2026-06-29 22:51         ` Sam Day
2026-06-30 14:47           ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=746aa10f-65e4-46d0-8db4-bc6314343f9d@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@samcday.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®